Mark label/title as RenderableType#5148
Closed
thejcannon wants to merge 1 commit intoTextualize:mainfrom
thejcannon:patch-1
Closed
Mark label/title as RenderableType#5148thejcannon wants to merge 1 commit intoTextualize:mainfrom thejcannon:patch-1
label/title as RenderableType#5148thejcannon wants to merge 1 commit intoTextualize:mainfrom
thejcannon:patch-1
Conversation
Member
|
Hey, this is marked as a draft - is it ready for review? |
Author
|
Oh yeah! My bad. I usually mark draft and make sure CI is passing before opening for review, but forgot to mark after CI. |
willmcgugan
requested changes
Nov 29, 2024
Member
willmcgugan
left a comment
willmcgugan
left a comment
There was a problem hiding this comment.
I think we would need to type the label reactive with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Howdy!
I spent an embarrassingly long time figuring out how to get a
Staticto be thetitleof aCollapsable, so much so I forked this repo and prepared a change to support it (which, I might add, didn't work).And then after staring at my own code for long enough it hit me. The title is already a
Static, solabel/titlemust be aRenderableType.Since
RenderableTypeincludesstrthis should be 100% backwards compatible with all existing usage.