update: 1.20.4

build.gradle

@@ -47,13 +47,6 @@ sourceSets.main.resources {
     srcDir 'src/generated/resources'
 }
 
-subsystems {
-    parchment {
-        minecraftVersion = project.mc_version
-        mappingsVersion = project.mappings
-    }
-}
-
 dependencies {
     implementation "net.neoforged:neoforge:${project.neoforge_version}"
 

docs/CHANGELOG.md

@@ -1,3 +1,7 @@
+# Enhanced Extinguishing - NeoForge - 1.0.0-1.20.4
+
+- Port to 1.20.4.
+
 # Enhanced Extinguishing - NeoForge - 1.0.0-1.20.2
 
 - Port to 1.20.2.

docs/README.md

@@ -32,7 +32,7 @@ If you're interested in sponsoring Enhanced Extinguishing or The Aether Team, pl
 [![Modrinth Version](https://img.shields.io/modrinth/game-versions/FDrEl7QY?color=00AF5C&label=latest&logo=modrinth&last=true)](https://modrinth.com/mod/aether-enhanced-extinguishing)
 [![CurseForge Downloads](http://cf.way2muchnoise.eu/884860.svg)](https://www.curseforge.com/minecraft/mc-mods/aether-enhanced-extinguishing)
 [![CurseForge Version](http://cf.way2muchnoise.eu/versions/884860_latest.svg)](https://www.curseforge.com/minecraft/mc-mods/aether-enhanced-extinguishing)
-[![CircleCI](https://circleci.com/gh/The-Aether-Team/Enhanced-Extinguishing/tree/1.20.2-develop.svg?style=shield)](https://app.circleci.com/pipelines/github/The-Aether-Team/Enhanced-Extinguishing?branch=1.20.2-develop)
+[![CircleCI](https://circleci.com/gh/The-Aether-Team/Enhanced-Extinguishing/tree/1.20.4-develop.svg?style=shield)](https://app.circleci.com/pipelines/github/The-Aether-Team/Enhanced-Extinguishing?branch=1.20.4-develop)
 ### Release builds
 Enhanced Extinguished has stable release builds available on [Modrinth](https://modrinth.com/mod/aether-enhanced-extinguishing) and [CurseForge](https://www.curseforge.com/minecraft/mc-mods/aether-enhanced-extinguishing).
 
@@ -97,13 +97,13 @@ dependencies {
 If you're running into bugs or other problems, feel free to open an issue on our [issue tracker](https://github.com/The-Aether-Team/Enhanced-Extinguishing/issues). When doing so, make sure to use one of the provided templates and fill out all the requested information. Make sure to keep your issue's description clear and concise. Your issue's title should also be easy to digest, giving our developers and reporters a good idea of what's wrong without including too many details. Failure to follow any of the above may result in your issue being closed.
 
 ## :wrench: Contribute to the project
-Looking to contribute to the project? We ask that you read over our [Contributor's Guide](https://github.com/The-Aether-Team/Enhanced-Extinguishing/blob/1.20.2-develop/docs/CONTRIBUTING.md) for more details as well as our [Contributor License Agreement (CLA)](https://github.com/The-Aether-Team/Enhanced-Extinguishing/blob/1.20.2-develop/docs/AGREEMENT.md) before getting started.
+Looking to contribute to the project? We ask that you read over our [Contributor's Guide](https://github.com/The-Aether-Team/Enhanced-Extinguishing/blob/1.20.4-develop/docs/CONTRIBUTING.md) for more details as well as our [Contributor License Agreement (CLA)](https://github.com/The-Aether-Team/Enhanced-Extinguishing/blob/1.20.4-develop/docs/AGREEMENT.md) before getting started.
 
 Not sure what to help with? Take a look at our issue tracker for some ideas! [Here's a quick link](https://github.com/The-Aether-Team/Enhanced-Extinguishing/labels/status%2Fhelp-wanted) which shows all the currently open issues that we'd love some help on.
 
 ## :scroll: License information
 [![Asset license (Unlicensed)](https://img.shields.io/badge/assets%20license-All%20Rights%20Reserved-red.svg?style=flat-square)](https://en.wikipedia.org/wiki/All_rights_reserved)
-[![Code license (LGPL v3.0)](https://img.shields.io/badge/code%20license-LGPL%20v3.0-green.svg?style=flat-square)](https://github.com/The-Aether-Team/Enhanced-Extinguishing/blob/1.20.2-develop/LICENSE.txt)
+[![Code license (LGPL v3.0)](https://img.shields.io/badge/code%20license-LGPL%20v3.0-green.svg?style=flat-square)](https://github.com/The-Aether-Team/Enhanced-Extinguishing/blob/1.20.4-develop/LICENSE.txt)
 
 If you're wanting to create a gameplay video/review, extension or addon, parody, or any other fan work of your own for Enhanced Extinguishing, go for it! We love seeing the content our community creates, and we hope to make it as welcoming as possible for everyone. We ask however that you please don't advertise using our brand (our specific logo assets, team name, official social media posts).
 

gradle.properties

@@ -3,18 +3,21 @@
 org.gradle.jvmargs=-Xmx3G
 org.gradle.daemon=false
 
+neogradle.subsystems.parchment.minecraftVersion=1.20.3
+neogradle.subsystems.parchment.mappingsVersion=2023.12.31
+
 # Mod
 mod_id=aether_enhanced_extinguishing
 mod_name=Enhanced Extinguishing
 mod_version=1.0.0
-mc_version=1.20.2
-neoforge_version=20.2.88
-mappings=2023.12.10
+mc_version=1.20.4
+neoforge_version=20.4.200
+mappings=2023.12.31
 
 # Dependencies
-aether_version=1.20.2-1.3.1-neoforge
-nitrogen_version=1.20.2-1.0.23-neoforge
-curios_version=6.1.0
+aether_version=1.20.4-1.4.0-neoforge
+nitrogen_version=1.20.4-1.1.0-neoforge
+curios_version=7.3.4
 
 # Publishing
 curseforge_id=884860

gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists

src/generated/resources/.cache/0f202e000d40347127b33b6edbbb29689b8cbf86

@@ -1,2 +1,2 @@
-// 1.19.4	2023-07-03T21:03:24.7351096	Pack Metadata
-18f2c92d6fe03e61b05b34bbe1cecc1f9a120bb4 pack.mcmeta
+// 1.20.4	2024-04-14T15:46:57.3951905	Pack Metadata
+de99a201253d77c4d1edbc458cae0e4e16616504 pack.mcmeta

src/generated/resources/.cache/2166f48f9b4916f698a3684df8f4ab46a095eeb0

@@ -1,4 +1,4 @@
-// 1.19.4	2023-07-03T23:10:28.5146643	Block States: aether_enhanced_extinguishing
+// 1.20.4	2024-04-14T15:46:57.353201	Block States: aether_enhanced_extinguishing
 be96f08f1470b00455e456ffac7da41c9f0e8733 assets/aether_enhanced_extinguishing/blockstates/extinguished_lantern.json
 1bb429c2685ac1c94b1ca8795435867ba4841af0 assets/aether_enhanced_extinguishing/blockstates/extinguished_torch.json
 70e801f59cf3a10a6d79092625ee69fda39fd417 assets/aether_enhanced_extinguishing/blockstates/extinguished_wall_torch.json

src/generated/resources/.cache/c622617f6fabf890a00b9275cd5f643584a8a2c8 → src/generated/resources/.cache/6073c70f3dc7ed4d31a0769270b3be4bdbc0ddc8

@@ -1,2 +1,2 @@
-// 1.19.4	2023-07-03T23:36:43.1696061	Languages: en_us
+// 1.20.4	2024-04-14T15:46:57.3661897	Languages: en_us for mod: aether_enhanced_extinguishing
 054564165425aec5b35ec63fa09c6f85272c2631 assets/aether_enhanced_extinguishing/lang/en_us.json

src/generated/resources/.cache/86e7b08150d5b7fd5e503c2765dc35f846e63e54

@@ -1,3 +1,3 @@
-// 1.19.4	2023-07-03T22:19:00.5615687	Tags for minecraft:block mod id aether_enhanced_extinguishing
+// 1.20.4	2024-04-14T15:46:57.3841903	Tags for minecraft:block mod id aether_enhanced_extinguishing
 23c668e2f3ed8790a22a0233bcd29f822790b43c data/minecraft/tags/blocks/mineable/pickaxe.json
 fd6aefed57ca423ecaac7dc14dc0632f95e2f748 data/minecraft/tags/blocks/wall_post_override.json

src/generated/resources/.cache/9fb1092f32d4fcbf9e061ffd718d4ec689c6c95e

@@ -1,4 +1,4 @@
-// 1.19.4	2023-07-03T22:59:22.8517548	Recipes
+// 1.20.4	2024-04-14T15:46:57.3791892	Recipes
 e7ba7064e57c5c3f475280bf81c391cb26f95631 data/aether_enhanced_extinguishing/recipes/lantern_extinguishing_conversion.json
 dae2cd7d4dacfb738e50e5df6381ce5f63c1597d data/aether_enhanced_extinguishing/recipes/torch_extinguishing_conversion.json
 e251b826224ea3c46cc4699f272548ae8e9330e4 data/aether_enhanced_extinguishing/recipes/wall_torch_extinguishing_conversion.json

src/generated/resources/pack.mcmeta

@@ -3,7 +3,10 @@
     "description": {
       "translate": "pack.aether_enhanced_extinguishing.mod.description"
     },
-    "forge:server_data_pack_format": 12,
-    "pack_format": 13
+    "pack_format": 26,
+    "supported_formats": [
+      0,
+      2147483647
+    ]
   }
 }

src/main/java/com/aetherteam/enhanced_extinguishing/EnhancedExtinguishing.java

@@ -6,6 +6,7 @@
 import com.aetherteam.enhanced_extinguishing.data.generators.ExtinguishingRecipeData;
 import com.aetherteam.enhanced_extinguishing.data.generators.tags.ExtinguishingBlockTagData;
 import com.mojang.logging.LogUtils;
+import net.minecraft.DetectedVersion;
 import net.minecraft.SharedConstants;
 import net.minecraft.core.HolderLookup;
 import net.minecraft.data.DataGenerator;
@@ -18,6 +19,7 @@
 import net.minecraft.server.packs.repository.Pack;
 import net.minecraft.server.packs.repository.PackCompatibility;
 import net.minecraft.server.packs.repository.PackSource;
+import net.minecraft.util.InclusiveRange;
 import net.minecraft.world.flag.FeatureFlagSet;
 import net.neoforged.api.distmarker.Dist;
 import net.neoforged.bus.api.IEventBus;
@@ -31,7 +33,7 @@
 
 import java.nio.file.Path;
 import java.util.List;
-import java.util.Map;
+import java.util.Optional;
 import java.util.concurrent.CompletableFuture;
 
 @Mod(EnhancedExtinguishing.MODID)
@@ -67,10 +69,10 @@ public void dataSetup(GatherDataEvent event) {
         generator.addProvider(event.includeServer(), new ExtinguishingBlockTagData(packOutput, lookupProvider, fileHelper));
 
         // pack.mcmeta
-        PackMetadataGenerator packMeta = new PackMetadataGenerator(packOutput);
-        Map<PackType, Integer> packTypes = Map.of(PackType.SERVER_DATA, SharedConstants.getCurrentVersion().getPackVersion(PackType.SERVER_DATA));
-        packMeta.add(PackMetadataSection.TYPE, new PackMetadataSection(Component.translatable("pack.aether_enhanced_extinguishing.mod.description"), SharedConstants.getCurrentVersion().getPackVersion(PackType.CLIENT_RESOURCES), packTypes));
-        generator.addProvider(true, packMeta);
+        generator.addProvider(true, new PackMetadataGenerator(packOutput).add(PackMetadataSection.TYPE, new PackMetadataSection(
+                Component.translatable("pack.aether_enhanced_extinguishing.mod.description"),
+                DetectedVersion.BUILT_IN.getPackVersion(PackType.SERVER_DATA),
+                Optional.of(new InclusiveRange<>(0, Integer.MAX_VALUE)))));
     }
 
     public void packSetup(AddPackFindersEvent event) {
@@ -88,7 +90,7 @@ private void setupRecipeOverridePack(AddPackFindersEvent event) {
                             Component.literal(""),
                             true,
                             new PathPackResources.PathResourcesSupplier(resourcePath, true),
-                            new Pack.Info(metadata.description(), metadata.packFormat(PackType.SERVER_DATA), metadata.packFormat(PackType.CLIENT_RESOURCES), PackCompatibility.COMPATIBLE, FeatureFlagSet.of(), List.of(), true),
+                            new Pack.Info(metadata.description(), PackCompatibility.COMPATIBLE, FeatureFlagSet.of(), List.of(), true),
                             Pack.Position.TOP,
                             false,
                             PackSource.BUILT_IN)

src/main/java/com/aetherteam/enhanced_extinguishing/block/ExtinguishedLanternBlock.java

@@ -3,7 +3,7 @@
 import net.minecraft.core.BlockPos;
 import net.minecraft.world.entity.player.Player;
 import net.minecraft.world.item.ItemStack;
-import net.minecraft.world.level.BlockGetter;
+import net.minecraft.world.level.LevelReader;
 import net.minecraft.world.level.block.Blocks;
 import net.minecraft.world.level.block.LanternBlock;
 import net.minecraft.world.level.block.state.BlockState;
@@ -20,7 +20,7 @@ public String getDescriptionId() {
     }
 
     @Override
-    public ItemStack getCloneItemStack(BlockState state, HitResult target, BlockGetter level, BlockPos pos, Player player) {
+    public ItemStack getCloneItemStack(BlockState state, HitResult target, LevelReader level, BlockPos pos, Player player) {
         return Blocks.LANTERN.getCloneItemStack(state, target, level, pos, player);
     }
 }

src/main/java/com/aetherteam/enhanced_extinguishing/block/ExtinguishedTorchBlock.java

@@ -28,7 +28,7 @@ public String getDescriptionId() {
     }
 
     @Override
-    public ItemStack getCloneItemStack(BlockState state, HitResult target, BlockGetter level, BlockPos pos, Player player) {
+    public ItemStack getCloneItemStack(BlockState state, HitResult target, LevelReader level, BlockPos pos, Player player) {
         return Blocks.TORCH.getCloneItemStack(state, target, level, pos, player);
     }
 

src/main/java/com/aetherteam/enhanced_extinguishing/block/ExtinguishedWallTorchBlock.java

@@ -37,7 +37,7 @@ public String getDescriptionId() {
     }
 
     @Override
-    public ItemStack getCloneItemStack(BlockState state, HitResult target, BlockGetter level, BlockPos pos, Player player) {
+    public ItemStack getCloneItemStack(BlockState state, HitResult target, LevelReader level, BlockPos pos, Player player) {
         return Blocks.WALL_TORCH.getCloneItemStack(state, target, level, pos, player);
     }
 

src/main/java/com/aetherteam/enhanced_extinguishing/data/generators/ExtinguishingRecipeData.java

@@ -6,12 +6,10 @@
 import com.aetherteam.enhanced_extinguishing.data.providers.ExtinguishingRecipeProvider;
 import net.minecraft.core.HolderLookup;
 import net.minecraft.data.PackOutput;
-import net.minecraft.data.recipes.FinishedRecipe;
 import net.minecraft.data.recipes.RecipeOutput;
 import net.minecraft.world.level.block.Blocks;
 
 import java.util.concurrent.CompletableFuture;
-import java.util.function.Consumer;
 
 public class ExtinguishingRecipeData extends ExtinguishingRecipeProvider {
     public ExtinguishingRecipeData(PackOutput output, CompletableFuture<HolderLookup.Provider> lookupProvider) {

src/main/java/com/aetherteam/enhanced_extinguishing/data/providers/ExtinguishingRecipeProvider.java

@@ -1,9 +1,8 @@
 package com.aetherteam.enhanced_extinguishing.data.providers;
 
-import com.aetherteam.aether.recipe.AetherRecipeSerializers;
 import com.aetherteam.aether.recipe.builder.BiomeParameterRecipeBuilder;
+import com.aetherteam.aether.recipe.recipes.block.PlacementConversionRecipe;
 import com.aetherteam.nitrogen.recipe.BlockStateIngredient;
-import com.aetherteam.nitrogen.recipe.builder.BlockStateRecipeBuilder;
 import net.minecraft.core.HolderLookup;
 import net.minecraft.data.PackOutput;
 import net.minecraft.data.recipes.RecipeProvider;
@@ -26,7 +25,7 @@ protected static ResourceLocation name(String name) {
         return new ResourceLocation(ID, name);
     }
 
-    protected static BlockStateRecipeBuilder convertPlacement(Block result, Block ingredient, TagKey<Biome> biome) {
-        return BiomeParameterRecipeBuilder.recipe(BlockStateIngredient.of(ingredient), result, biome, AetherRecipeSerializers.PLACEMENT_CONVERSION.get());
+    protected static BiomeParameterRecipeBuilder convertPlacement(Block result, Block ingredient, TagKey<Biome> biome) {
+        return BiomeParameterRecipeBuilder.recipe(BlockStateIngredient.of(ingredient), result, biome, PlacementConversionRecipe::new);
     }
 }

src/main/resources/META-INF/mods.toml

@@ -7,7 +7,7 @@ issueTrackerURL="https://github.com/The-Aether-Team/Enhanced-Extinguishing/issue
 modId = "aether_enhanced_extinguishing"
 version = "${file.jarVersion}"
 displayName = "Enhanced Extinguishing"
-updateJSONURL="https://github.com/The-Aether-Team/Enhanced-Extinguishing/raw/1.20.2-develop/update.json"
+updateJSONURL="https://github.com/The-Aether-Team/Enhanced-Extinguishing/raw/1.20.4-develop/update.json"
 displayURL = "https://modrinth.com/mod/aether-enhanced-extinguishing"
 logoFile ="enhanced_extinguishing_icon.png"
 credits = "The Aether Team"
@@ -16,19 +16,19 @@ description = '''Improves the consistency of fire being disallowed in the Aether
 
 [[dependencies.aether_enhanced_extinguishing]]
     modId="neoforge"
-    mandatory=true
-    versionRange="[20.2.0,)"
+    type = "required"
+    versionRange="[20.4.167,)"
     ordering="NONE"
     side="BOTH"
 [[dependencies.aether_enhanced_extinguishing]]
     modId = "aether"
-    mandatory = true
-    versionRange = "[1.20.1-1.0.0-beta.1-forge,)"
+    type = "required"
+    versionRange = "[1.20.4-1.4.0-neoforge,)"
     ordering = "NONE"
     side = "BOTH"
 [[dependencies.aether_enhanced_extinguishing]]
     modId = "minecraft"
-    mandatory = true
-    versionRange="[1.20.2,1.20.3)"
+    type = "required"
+    versionRange="[1.20.4]"
     ordering = "NONE"
     side = "BOTH"

update.json

@@ -4,6 +4,7 @@
     "1.19.2-recommended": "1.19.2-1.0.0-forge",
     "1.19.4-recommended": "1.19.4-1.0.0-forge",
     "1.20.1-recommended": "1.20.1-1.0.0-neoforge",
-    "1.20.2-recommended": "1.20.2-1.0.0-neoforge"
+    "1.20.2-recommended": "1.20.2-1.0.0-neoforge",
+    "1.20.4-recommended": "1.20.4-1.0.0-neoforge"
   }
 }