build: fix pythonwrapper brittleness and split pip requirements#534
Merged
build: fix pythonwrapper brittleness and split pip requirements#534
Conversation
Replace the brittle subprocess + PYTHONPATH propagation hack in pythonwrapper/python.py with runpy.run_path(), which runs scripts in-process and inherits sys.path natively. This avoids breakage when rules_python changes its bootstrap (as happened with 1.7+). Split requirements.in into three tiers so downstream consumers of bazel-orfs only resolve the packages they actually need: - Core (requirements.in): PyYAML only — needed by ORFS flow - Features (requirements_features.in): matplotlib, najaeda — for orfs_ppa() and naja - Examples (requirements_examples.in, dev_dependency): pandas, optuna, plotly, kaleido — for DSE and test plots Also drop dead pandas dependency from pythonwrapper (no ORFS flow script imports it). Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: Øyvind Harboe <[email protected]>
Collaborator
Author
|
@maliberty @hzeller FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the brittle subprocess + PYTHONPATH propagation hack in pythonwrapper/python.py with runpy.run_path(), which runs scripts in-process and inherits sys.path natively. This avoids breakage when rules_python changes its bootstrap (as happened with 1.7+).
Split requirements.in into three tiers so downstream consumers of bazel-orfs only resolve the packages they actually need:
Also drop dead pandas dependency from pythonwrapper (no ORFS flow script imports it).