use correct config scope for release and custom cli profiles #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaAlbrecht
changed the title
DaAlbrecht
added
A-CLI
TimJentzsch
reviewed
May 3, 2025
src/build/mod.rs
Outdated
| args.subcommand = Some(BuildSubcommands::Web(BuildWebArgs::default())); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we integrate this logic directly into the is_release() functions of the args? Then e.g. also the wasm_opt detection works consistently with the config and we don't need to add other feature gated logic here
There was a problem hiding this comment.
Good call! What do you think now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://discord.com/channels/691052431525675048/1278871953721262090/1367460269412057149
Before
bevy build --release bevy build --profile release # Become these cargo commands: cargo build --features native --profile release cargo build --features native,native_dev --profile releaseNow
Build:
❯ bevy build --profile web-release -v DEBUG Using defaults from bevy_cli config: features = [] default_features = false rustflags = ["--cfg", 'getrandom_backend="wasm_js"'] INFO Compiling to WebAssembly... DEBUG Running: `cargo build --config profile.web.inherits="dev" --no-default-features --profile web-release --target wasm32-unknown-unknown` DEBUG With env: RUSTFLAGS=--cfg getrandom_backend="wasm_js" Finished `web-release` profile [optimized] target(s) in 0.12s INFO Bundling JavaScript bindings... DEBUG Running: `wasm-bindgen --no-typescript --out-name bevy_new_2d --out-dir bevy_new_2d/target/wasm32-unknown-unknown/web-release --target web / bevy_new_2d/target/wasm32-unknown-unknown/web-release/bevy_new_2d.wasm` INFO No custom `web` folder found, using defaults.Run:
❯ bevy run --profile web-release -v DEBUG Using defaults from bevy_cli config: features = [] default_features = false rustflags = ["--cfg", 'getrandom_backend="wasm_js"'] INFO Compiling to WebAssembly... DEBUG Running: `cargo build --config profile.web.inherits="dev" --bin bevy_new_2d --no-default-features --profile web-release --target wasm32-unknown-unknown` DEBUG With env: RUSTFLAGS=--cfg getrandom_backend="wasm_js" Finished `web-release` profile [optimized] target(s) in 0.12s INFO Bundling JavaScript bindings... DEBUG Running: `wasm-bindgen --no-typescript --out-name bevy_new_2d --out-dir bevy_new_2d/target/wasm32-unknown-unknown/web-release --target web bevy_new_2d/target/wasm32-unknown-unknown/web-release/bevy_new_2d.wasm` INFO No custom `web` folder found, using defaults. INFO Open your app at <http://localhost:4000>!❯ bevy run -r web -v DEBUG Using defaults from bevy_cli config: features = [] default_features = false rustflags = ["--cfg", 'getrandom_backend="wasm_js"'] INFO Compiling to WebAssembly... DEBUG Running: `cargo build --config profile.web.inherits="dev" --bin bevy_new_2d --no-default-features --profile web-release --target wasm32-unknown-unknown` DEBUG With env: RUSTFLAGS=--cfg getrandom_backend="wasm_js" Finished `web-release` profile [optimized] target(s) in 0.13s INFO Bundling JavaScript bindings... DEBUG Running: `wasm-bindgen --no-typescript --out-name bevy_new_2d --out-dir bevy_new_2d/target/wasm32-unknown-unknown/web-release --target web /bevy_new_2d/target/wasm32-unknown-unknown/web-release/bevy_new_2d.wasm` INFO No custom `web` folder found, using defaults. INFO Open your app at <http://localhost:4000>!