Skip to content

remove unused lockfile command #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

ChristopherBiscardi
Copy link
Contributor

Currently when running bevy new to generate a new project with this template, the user is prompted to run a script.

image

The lockfile update script was initially added as a way to make it so that users could generate a new bevy_new_2d project, immediately commit after generating, and have the github workflows work. (The workflows are written to require --locked in that template).

This script is neither explained to the user nor required for the current functionality in this template so this PR removes the unused lockfile command so that it doesn't prompt the user to run it every time a new template is created.

@benfrankel benfrankel added C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to start contributing and removed C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to start contributing labels Jan 23, 2025
@benfrankel
Copy link
Collaborator

benfrankel commented Jan 23, 2025

I think a ci.yaml should be added to this template, but the post-generate.rhai line can easily be copy-pasted back from bevy_new_2d when that happens. This PR is a usability improvement in the meantime.

@benfrankel benfrankel merged commit b542dd6 into TheBevyFlock:main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants