Skip to content

Fixed unresponsive ui during window resize #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zod24 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed unresponsive ui during window resize #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 26 additions & 21 deletions Hazel/src/Hazel/Core/Application.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,37 +90,40 @@ namespace Hazel {
{
HZ_PROFILE_FUNCTION();

while (m_Running)
{
while (m_Running) {
HZ_PROFILE_SCOPE("RunLoop");
OnUpdate();
}
}

float time = Time::GetTime();
Timestep timestep = time - m_LastFrameTime;
m_LastFrameTime = time;
void Application::OnUpdate()
{
float time = Time::GetTime();
Timestep timestep = time - m_LastFrameTime;
m_LastFrameTime = time;

ExecuteMainThreadQueue();
ExecuteMainThreadQueue();

if (!m_Minimized)
if (!m_Minimized)
{
{
{
HZ_PROFILE_SCOPE("LayerStack OnUpdate");
HZ_PROFILE_SCOPE("LayerStack OnUpdate");

for (Layer* layer : m_LayerStack)
layer->OnUpdate(timestep);
}
for (Layer* layer : m_LayerStack)
layer->OnUpdate(timestep);
}

m_ImGuiLayer->Begin();
{
HZ_PROFILE_SCOPE("LayerStack OnImGuiRender");
m_ImGuiLayer->Begin();
{
HZ_PROFILE_SCOPE("LayerStack OnImGuiRender");

for (Layer* layer : m_LayerStack)
layer->OnImGuiRender();
}
m_ImGuiLayer->End();
for (Layer* layer : m_LayerStack)
layer->OnImGuiRender();
}

m_Window->OnUpdate();
m_ImGuiLayer->End();
}

m_Window->OnUpdate();
}

bool Application::OnWindowClose(WindowCloseEvent& e)
Expand All @@ -142,6 +145,8 @@ namespace Hazel {
m_Minimized = false;
Renderer::OnWindowResize(e.GetWidth(), e.GetHeight());

OnUpdate();

return false;
}

Expand Down
1 change: 1 addition & 0 deletions Hazel/src/Hazel/Core/Application.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ namespace Hazel {
void SubmitToMainThread(const std::function<void()>& function);
private:
void Run();
void OnUpdate();
bool OnWindowClose(WindowCloseEvent& e);
bool OnWindowResize(WindowResizeEvent& e);

Expand Down