Problem: clang-format application can be overzealous#43
Open
yrashk wants to merge 1 commit intoTheLartians:masterfrom
Open
Problem: clang-format application can be overzealous#43yrashk wants to merge 1 commit intoTheLartians:masterfrom
yrashk wants to merge 1 commit intoTheLartians:masterfrom
Conversation
Solution: allow excluding certain paths by specifying them in the CLANG_FORMAT_IGNORED_PATHS list
Contributor
|
What is your use case? It should do the same like git clang-format |
Owner
Contributor
|
But than you need to update your copy of clang-format.py to llvm v18 or newer! |
Author
|
And that would require clang-format to be of a newer version, too! 😀 |
Contributor
|
@TheLartians first off all the CI Must be fixed! And #41 should be merged 😮 |
Owner
|
Sorry, the CI issue should be fixed now if you merge with main. I'm happy with using newer versions of the according formatting tools, but also with adding the suggested flag for scenarios where this is not possible. (also apologies for taking so long to respond, very busy atm) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: allow excluding certain paths
by specifying them in the CLANG_FORMAT_IGNORED_PATHS list
This is just a quick solution to a problem I had with a lot of vendored dependencies in the repo where I needed this. Happy to discuss if there's a better solution!