Fix extra files not being recognized on MacOS #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLastGimbus
force-pushed
the
macos-filenames
branch
from
ce539df to
d57c746
Compare
|
hey hey ...i'm done 👀 try it on your blazing fast M1: https://github.com/TheLastGimbus/GooglePhotosTakeoutHelper/actions/runs/6280457253 ...also, if you could test out if this doesn't break stuff on linux or especially windoza, i would be grateful 🙏 |
|
Tested successfully on my blazing fast M1. Great job ! (For the record , 4169 photos with 19 albums processed in 7,56s ). I can't test on W*s, sorry. |
DAMN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of comment for future generations:
As @palijn nicely summarised it - "Linux file systems use NFC where MAC FS choose NFD" - which, said NFD, doesn't
==accents and other unicode stuff with our extras collectionThis caused #204 (we didn't have separate
-modifethen but I added regex option that still didn't work), then #243, and probably few other issuesI really thought we had all of the "encoding something something" nightmare resolved ages ago -_-
So, merging this closes #243 :)