Handle edge case where image file was uploaded without an extension #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any feedback is appreciated :) |
|
I'm very happy that with this existing 4 years, people still find these 🥲 |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my Google Photos Takeout I had some weird files where the json filename didn't include the extension of the image.
Example:
2013-08-22.jsonfor image2013-08-22.png.This happened because the image was originally uploaded without an extension, which is underpinned by the fact that the json file says
"title": "2013-08-22".Google Photos added the png extension (also have cases with jpg) automatically but didn't include this in the title field or json filename.
To handle such cases correctly we need to try to look for a json file while ignoring the filename.