-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made a few grammatical changes #29422
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to improve this lesson. I've requested a few changes. In addition, you need to fill out this pull request with the details in the "Because" and "This PR" section. Please do not mark these as completed in the "Requirements" section until they have been filled out.
In addition, the title of this PR is not in the required format that you've marked as completed as well.
Having these details make it easier for the maintainer team to scan through the open PRs to get them reviewed, as well as the details to help us understand the reasons for making these changes. Please take a few minutes and review our contributing guide, which is linked in the requirements section.
|
||
Our foundations lessons by design only scratched the surface of what's possible. We wanted to give you all of the bare necessities for getting started so you could move on and be somewhat productive as quickly as possible, but now it's time to slow down and dig in! | ||
Our foundation lessons by design only scratched the surface of what's possible. We wanted to give you all of the bare necessities for getting started so you could move on and be somewhat productive as quickly as possible, but now it's time to slow down and dig in! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is referring to our Foundations course, so perhaps rephrasing the whole sentence would be better.
The lessons in our Foundations course only scratched the surface of what's possible...
|
||
You have probably realized by now that there are many more HTML elements than we mentioned in our foundations content. Throughout this course, we'll be hitting the rest of the important elements such as forms and tables. | ||
You have probably realized by now that there are many more HTML elements than we mentioned in our foundation content. Throughout this course, we'll be hitting the rest of the important elements such as forms and tables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, this could be
... mentioned in our Foundations course
|
||
There is also a _lot_ more that you can do with CSS that you'll learn throughout this course, such as variables, functions, shadows and of course grid layouts! So buckle up! By the time you finish this course, you'll be able to recreate just about any web design you can find on the internet... which is an important skill to carry forward. Even if you are not shooting for a front-end specific job, being able to make your portfolio pieces look nice is important when it comes to making yourself stand out. | ||
There is also a _lot_ more that you can do with CSS that you'll learn throughout this course, such as variables, functions, shadows and of course grid layouts! So buckle up! By the time you finish this course, you'll be able to recreate just about any web design you can find on the internet... which is an important skill to carry forward. Even if you are not shooting for a front-end-specific job, being able to make your portfolio pieces look nice is important when it comes to making yourself stand out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not believe this needs an hyphen. Having two seems like overkill and I'd rather re-phrase that sentence if you strongly feel it needs to be here.
Even if you are not shooting for a front-end job, being able...
Because
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section