Skip to content

Rails Turbo Drive: Add knowledge check section with 7 questions #29862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Monatric
Copy link
Contributor

Because

The Turbo Drive lesson is oddly missing knowledge checks, in contrast with other lessons that do contain them. This PR adds 7 knowledge check questions, with links to the answer, and added some span tags as necessary. This PR should allow users to reflect more towards link navigation with Turbo.

This PR

  • Add 7 knowledge check questions
  • Add 3 span tags for redirection to the answer

Issue

Closes #29803

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Jul 10, 2025
@Monatric
Copy link
Contributor Author

Monatric commented Jul 10, 2025

It seems that there are a lot of linting errors. May I fix these stuff too?

If so, how would I run linters locally instead of having to push everytime and get GitHub to run the checks?

@rlmoser99 rlmoser99 requested review from a team and linkonsat and removed request for a team July 11, 2025 02:31
@MaoShizhong
Copy link
Contributor

It seems that there are a lot of linting errors. May I fix these stuff too?

If so, how would I run linters locally instead of having to push everytime and get GitHub to run the checks?

Not a maint so not saying you need to fix the lint errors now, but to do linting stuff locally, instructions are in this repo's CONTRIBUTING.md

@Monatric
Copy link
Contributor Author

Not a maint so not saying you need to fix the lint errors now, but to do linting stuff locally, instructions are in this repo's CONTRIBUTING.md

Sorry, are you referencing to this link? I really can't find the instructions. https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md

@MaoShizhong
Copy link
Contributor

Sorry, are you referencing to this link? I really can't find the instructions. https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md

No, that's the general contributing guide in the .github repo. I mean this repo's CONTRIBUTING.md.

@Monatric
Copy link
Contributor Author

Ah I see, thank you. That's my first time seeing that 🤔.

@JoshDevHub JoshDevHub requested review from JoshDevHub and removed request for linkonsat July 18, 2025 18:34
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this PR @Monatric

I have a couple recommended changes to the knowledge check links, and while we're here in this file, we should go ahead and fix the Markdown lint errors. Let me know if you have any questions about any of this.


The following questions are an opportunity to reflect on key topics in this lesson. If you can't answer a question, click on it to review the material, but keep in mind you are not expected to memorize or master this knowledge.

- [What is page navigation defined by Turbo Drive?](https://www.theodinproject.com/lessons/ruby-on-rails-turbo-drive#page-navigation)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [What is page navigation defined by Turbo Drive?](https://www.theodinproject.com/lessons/ruby-on-rails-turbo-drive#page-navigation)
- [What is page navigation defined by Turbo Drive?](#page-navigation)

Section headings automatically have an id inserted for them, which means you can do internal page navigation through just the id.

This isn't just a keystroke saver either. If you were running this site in dev and serving on localhost:3000, you'd want the links to go to localhost:3000/lessons/ruby-on-rails-turbo-drive#page-navigation and not the actual production site. Just expressing that if you can, you want to avoid hardcoding the full production URL to a page (or section of a page).

Copy link
Contributor Author

@Monatric Monatric Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! But what's the next thing to do from here? Do I make changes locally or click "Commit suggestion" and "Resolve Conversation"?

I will work on it now but for now I will make the changes locally since I think the results would be the same anyway (i hope)

- [What is page navigation defined by Turbo Drive?](https://www.theodinproject.com/lessons/ruby-on-rails-turbo-drive#page-navigation)
- [What is the default visit action that adds a new entry to the browser history?](#visit-action)
- [How do you change the action of a Turbo Drive link?](#change-turbo-action)
- [How do you disable Turbo Drive?](https://www.theodinproject.com/lessons/ruby-on-rails-turbo-drive#disable-turbo-drive)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [How do you disable Turbo Drive?](https://www.theodinproject.com/lessons/ruby-on-rails-turbo-drive#disable-turbo-drive)
- [How do you disable Turbo Drive?](#disable-turbo-drive)

@Monatric
Copy link
Contributor Author

Thank you for making this PR @Monatric

I have a couple recommended changes to the knowledge check links, and while we're here in this file, we should go ahead and fix the Markdown lint errors. Let me know if you have any questions about any of this.

I think I resolved all lint errors now, though I have this slightly annoying issue once I installed the markdownlint VSCode extension, where if I run the npm run lint:lesson -- "./path/to/lesson", my terminal tab goes to Output automatically. That's not the only time it happened, but I am still unsure how to replicate this behavior. I'm not sure what the errors tell me too.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turbo Drive: Add knowledge check questions
3 participants