Add suport for sms #21

UnelDev · 2025-07-10T22:12:15Z

Pull Request Overview

This PR adds support for sending and managing SMS messages within the admin area.

Introduces a singleton Sms class for gateway integration, token management, and sending messages.
Extends utility functions for phone normalization and validation.
Adds three new endpoints (smsStatus, sendSms, setPhone), updates routes, tests, model, and docs.

Reviewed Changes

Copilot reviewed 20 out of 22 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tools/utils.ts	Updated phone validation logic
tools/sms.ts	New `Sms` class handling SMS gateway interactions
router/admin/area/smsStatus.ts	Implement `/admin/area/smsStatus` endpoint
router/admin/area/sendSms.ts	Implement `/admin/area/sendSms` endpoint
router/admin/area/setPhone.ts	Implement `/admin/area/setPhone` endpoint
routes.ts	Registered new SMS-related routes
Models/Area.ts	Added `adminPhone` field to `Area` schema
README.md	Added versioning section

Comments suppressed due to low confidence (1)

tools/sms.ts:10

The property name 'gatway' appears to be a typo. Rename it to 'gateway' for clarity and consistency.

	gatway: string;

Introduced a new /admin/area/setPhone endpoint to update admin phone numbers, including input validation and sanitization. Improved phone validation logic in sendSms and utils, clarified error messages, and updated routes to register the new endpoint. Also fixed a comment in sms.ts for clarity.

router/admin/area/setPhone.ts

Copilot

Pull Request Overview

This PR adds support for sending and managing SMS messages within the admin area.

Introduces a singleton Sms class for gateway integration, token management, and sending messages.
Extends utility functions for phone normalization and validation.
Adds three new endpoints (smsStatus, sendSms, setPhone), updates routes, tests, model, and docs.

Reviewed Changes

Copilot reviewed 20 out of 22 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tools/utils.ts	Updated phone validation logic
tools/sms.ts	New `Sms` class handling SMS gateway interactions
router/admin/area/smsStatus.ts	Implement `/admin/area/smsStatus` endpoint
router/admin/area/sendSms.ts	Implement `/admin/area/sendSms` endpoint
router/admin/area/setPhone.ts	Implement `/admin/area/setPhone` endpoint
routes.ts	Registered new SMS-related routes
Models/Area.ts	Added `adminPhone` field to `Area` schema
README.md	Added versioning section

Comments suppressed due to low confidence (1)

tools/sms.ts:10

The property name 'gatway' appears to be a typo. Rename it to 'gateway' for clarity and consistency.

	gatway: string;

Copilot · 2025-07-10T22:17:27Z

tools/utils.ts

@@ -57,6 +57,8 @@ function phoneNumberCheck(phone: string): boolean {
 	if (typeof phone != 'string') return false;
 	if (!phone.startsWith('+')) return false;

+	phone = phone.replace(' ', '');


Consider using replaceAll or a global regex (e.g., phone = phone.replace(/\s/g, '')) to remove all whitespace instead of only the first occurrence.

Suggested change

phone = phone.replace(' ', '');

phone = phone.replaceAll(' ', '');

Copilot · 2025-07-10T22:17:27Z

tools/sms.ts

+		//unactivate self-signed certificate by default if slef-signed is true
+		this.selfSigned = process.env.SMS_SELFSIGNED === 'true' ? false : true;


[nitpick] There's a typo in the comment ('slef-signed'). Also, the logic and comment are confusing; consider clarifying the intended behavior for self-signed certificate handling.

Suggested change

//unactivate self-signed certificate by default if slef-signed is true

this.selfSigned = process.env.SMS_SELFSIGNED === 'true' ? false : true;

// Disable self-signed certificate validation by default. If SMS_SELFSIGNED is 'true', allow self-signed certificates.

this.selfSigned = process.env.SMS_SELFSIGNED === 'true' ? true : false;

Copilot · 2025-07-10T22:17:27Z

tools/sms.ts

+					this.enabled = true;
+					return true;
+				} else {
+					this.enabled = true;


In the else branch, the gateway responded but didn't return the expected text; enabling SMS here may be incorrect. Consider setting enabled to false when the response text is unexpected.

Suggested change

this.enabled = true;

this.enabled = false;

Copilot · 2025-07-10T22:17:28Z

router/admin/area/sendSms.ts

+	}
+
+	let errored = false;
+	req.body.phone.map((phone: [string, string | undefined]) => {


[nitpick] Using map purely for side effects can be confusing. Consider using forEach or a simple for loop for validation instead.

Suggested change

req.body.phone.map((phone: [string, string | undefined]) => {

req.body.phone.forEach((phone: [string, string | undefined]) => {

Copilot · 2025-07-10T22:17:28Z

router/admin/area/smsStatus.ts

+		return;
+	}
+
+	const service = sms.enabled ? (sms.isSmsTools ? 'sms-tools' : 'sms-gateway') : 'inactif';


[nitpick] The fallback service label 'inactif' seems to mix French and English. Consider using 'inactive' for consistency.

Suggested change

const service = sms.enabled ? (sms.isSmsTools ? 'sms-tools' : 'sms-gateway') : 'inactif';

const service = sms.enabled ? (sms.isSmsTools ? 'sms-tools' : 'sms-gateway') : 'inactive';

no the language of application is French for all client data

Copilot · 2025-07-10T22:17:28Z

README.md

@@ -39,3 +39,10 @@ or
 ```bash
 npm run test file
 ```
+
+## versionning


There's a typo in the heading. 'versionning' should be 'versioning'.

Suggested change

## versionning

## versioning

## Pull Request Overview This PR adds support for sending and managing SMS messages within the admin area. - Introduces a singleton `Sms` class for gateway integration, token management, and sending messages. - Extends utility functions for phone normalization and validation. - Adds three new endpoints (`smsStatus`, `sendSms`, `setPhone`), updates routes, tests, model, and docs. ### Reviewed Changes Copilot reviewed 20 out of 22 changed files in this pull request and generated 6 comments. <details> <summary>Show a summary per file</summary> | File | Description | |------------------------------------|-------------------------------------------------------| | tools/utils.ts | Updated phone validation logic | | tools/sms.ts | New `Sms` class handling SMS gateway interactions | | router/admin/area/smsStatus.ts | Implement `/admin/area/smsStatus` endpoint | | router/admin/area/sendSms.ts | Implement `/admin/area/sendSms` endpoint | | router/admin/area/setPhone.ts | Implement `/admin/area/setPhone` endpoint | | routes.ts | Registered new SMS-related routes | | Models/Area.ts | Added `adminPhone` field to `Area` schema | | README.md | Added versioning section | </details> <details> <summary>Comments suppressed due to low confidence (1)</summary> **tools/sms.ts:10** * The property name 'gatway' appears to be a typo. Rename it to 'gateway' for clarity and consistency. ``` gatway: string; ``` </details>

UnelDev added 7 commits July 8, 2025 00:23

Create sms feature

880b8f2

fix test

4d56f57

add test suite for smsStatus, fix area type

196c587

add test for setPhone

7a7e982

add test for sendSms fix other test

072f604

update path of utils.test.ts

3e63389

github-advanced-security bot found potential problems Jul 10, 2025

View reviewed changes

router/admin/area/setPhone.ts Dismissed Show dismissed Hide dismissed

UnelDev requested a review from Copilot July 10, 2025 22:15

Copilot AI reviewed Jul 10, 2025

View reviewed changes

UnelDev self-assigned this Jul 10, 2025

review

55c824d

UnelDev force-pushed the add-suport-for-sms branch from 20b9615 to 55c824d Compare July 10, 2025 22:47

UnelDev merged commit c256120 into main Jul 10, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add suport for sms #21

Add suport for sms #21

Uh oh!

UnelDev commented Jul 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 10, 2025

Uh oh!

Copilot AI Jul 10, 2025

Uh oh!

Copilot AI Jul 10, 2025

Uh oh!

Copilot AI Jul 10, 2025

Uh oh!

Copilot AI Jul 10, 2025

Uh oh!

UnelDev Jul 10, 2025

Uh oh!

Copilot AI Jul 10, 2025

Uh oh!

Uh oh!

Uh oh!

	phone = phone.replace(' ', '');
	phone = phone.replaceAll(' ', '');

		//unactivate self-signed certificate by default if slef-signed is true
		this.selfSigned = process.env.SMS_SELFSIGNED === 'true' ? false : true;

	req.body.phone.map((phone: [string, string \| undefined]) => {
	req.body.phone.forEach((phone: [string, string \| undefined]) => {

	const service = sms.enabled ? (sms.isSmsTools ? 'sms-tools' : 'sms-gateway') : 'inactif';
	const service = sms.enabled ? (sms.isSmsTools ? 'sms-tools' : 'sms-gateway') : 'inactive';

Add suport for sms #21

Add suport for sms #21

Uh oh!

Conversation

UnelDev commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

UnelDev Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

UnelDev commented Jul 10, 2025 •

edited

Loading