fix #565: setup data after config loaded

[rndev-io]

No description provided.

[akyrey]

@rusnasonov thank you for the PR.

What about leaving the data initialization and sync_on_change function also inside Harpoon::new() and edit Harpoon::setup() like you did but with sync_on_change(self) moved right before the final return?

[rndev-io]

What about leaving the data initialization and sync_on_change function also inside Harpoon::new()

It's creates additional empty data file with default key, which will never be used. If it's ok - why not.

but with sync_on_change(self) moved right before the final return?

Ok

[maxrzaw]

This also fixes #577

[iserpent]

Found this MR just before creating my pull request :) Looks like it takes time to get it merged.
One suggestion from me would be to check at least for the partial_config to be non-empty. Otherwise we don't need to reload data and calling sync_on_change (e.g. if it was just harpoon.setup({})).

Suggested change

	self.data = Data.Data:new(self.config)
	if partial_config then
	self.data = Data.Data:new(self.config)
	end

(and the same if before calling sync_on_change).