Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telescope - Respect user preference on long file names #637

Open
wants to merge 1 commit into
base: harpoon2
Choose a base branch
from

Conversation

Sawyer-Powell
Copy link

@Sawyer-Powell Sawyer-Powell commented Oct 10, 2024

In the default provided telescope extension, the file picker can have some visual glitches and issues when displaying long file names. Telescope provides some configuration options for handling displaying long file names, including an option to set path_display = {"truncate"} to right align long file names, so you can see the actual file instead of the preceding directories. More info on this telescope feature here: nvim-telescope/telescope.nvim#895

This fix respects the users choice of display option, and fixes some visual issues I was seeing when using :Telescope harpoon marks. Some questions I have about improving the implementation:

  1. Since harpoon seems to moving to putting the telescope integration in the hands of a user's configuration file, should we even still be updating the provided Telescope picker?
  2. Should we try to reintegrate the harpoon index into the provided picker? (I removed it since it was not set in the table when I called harpoon:list())

Hope this is helpful!

Before:
Screenshot from 2024-10-10 10-44-26

After:
Screenshot from 2024-10-10 10-43-46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant