fix exception in notification plugin stopping further processing #847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that I did not get failure notifications via pushover anymore and looked into that.
The reason I found was, that another active plugin threw an exception due to an invalid token. Any further plugins were not called anymore, including pushover in my case.
For the general notifications, all plugin exceptions are handled, but that's not the case for the more important failure notifications.
To mitigate the issue, I added the same kind of error handling for failure notification as for general notifications.
Cheers