Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exception in notification plugin stopping further processing #847

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

vikwin
Copy link
Contributor

@vikwin vikwin commented Jan 4, 2024

Hi,
I noticed that I did not get failure notifications via pushover anymore and looked into that.

The reason I found was, that another active plugin threw an exception due to an invalid token. Any further plugins were not called anymore, including pushover in my case.

For the general notifications, all plugin exceptions are handled, but that's not the case for the more important failure notifications.
To mitigate the issue, I added the same kind of error handling for failure notification as for general notifications.

Cheers

@kennethjiang kennethjiang merged commit 0ded913 into TheSpaghettiDetective:master Jan 11, 2024
3 of 5 checks passed
@kennethjiang
Copy link
Contributor

Thank you so much for finding this problem and fixing it for us!

And my apologies for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants