-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support managed gateway capabilities #7439
Draft
johanstokking
wants to merge
8
commits into
v3.34
Choose a base branch
from
feature/managed-gateway-capabilities
base: v3.34
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c/gateway conf server
This is related to the Gateway Configuration Server
dependencies
Pull requests that update a dependency file
ui/web
This is related to a web interface
tooling
Development tooling
compat/config
This could affect Configuration compatibility
labels
Dec 10, 2024
johanstokking
force-pushed
the
feature/managed-gateway-capabilities
branch
from
December 11, 2024 13:43
170c0ad
to
a6aa597
Compare
PavelJankoski
requested changes
Dec 11, 2024
pkg/webui/console/containers/gateway-managed-gateway/connection-settings/index.js
Show resolved
Hide resolved
pkg/webui/console/containers/gateway-managed-gateway/connection-settings/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/gateway-managed-gateway/connection-settings/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/gateway-managed-gateway/connection-settings/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/gateway-managed-gateway/connection-settings/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/gateway-managed-gateway/connection-settings/index.js
Show resolved
Hide resolved
johanstokking
force-pushed
the
feature/managed-gateway-capabilities
branch
3 times, most recently
from
December 16, 2024 13:27
ef0b070
to
80c23b8
Compare
johanstokking
force-pushed
the
feature/managed-gateway-capabilities
branch
from
December 16, 2024 13:36
80c23b8
to
c95b393
Compare
PavelJankoski
requested changes
Dec 16, 2024
pkg/webui/console/containers/gateway-managed-gateway/connection-settings/index.js
Show resolved
Hide resolved
PavelJankoski
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE changes LGTM!
johanstokking
force-pushed
the
feature/managed-gateway-capabilities
branch
from
December 25, 2024 07:49
41adc32
to
6a25556
Compare
johanstokking
force-pushed
the
feature/managed-gateway-capabilities
branch
from
December 25, 2024 07:49
6a25556
to
7327564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c/gateway conf server
This is related to the Gateway Configuration Server
compat/config
This could affect Configuration compatibility
dependencies
Pull requests that update a dependency file
tooling
Development tooling
ui/web
This is related to a web interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for managed gateway capabilities, e.g. whether the gateway supports WiFi, ethernet, battery, etc.
Changes
Testing
Steps
This cannot be tested without the proper hardware. There is end-to-end testing.
Results
Regressions
None expected
Notes for Reviewers
@PavelJankoski please review frontend
This is draft until:
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.