Audio decoder issue fix for android.#4398
Open
rahulnainwal107 wants to merge 2 commits intoTheWidlarzGroup:support/6.x.xfrom
Open
Audio decoder issue fix for android.#4398rahulnainwal107 wants to merge 2 commits intoTheWidlarzGroup:support/6.x.xfrom
rahulnainwal107 wants to merge 2 commits intoTheWidlarzGroup:support/6.x.xfrom
Conversation
Collaborator
|
First thank you for the PR! |
Author
|
@freeboub Thanks for reviewing it. |
Collaborator
No problem, I think you should also rename the function to isCodecAudioSupported then ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I was facing an issue related to the audio decoder when the lang attribute was missing in manifest file for AdaptationSet tag and having multiple AdaptationSet, where 0th position audio is not supported by the device but 1st position audio is supported.
Changes
1- Default groupIndex updated.
int groupIndex = C.INDEX_UNSET; // default if no match2- Added a helper function for checking supported audio codes.
3- If audio is supported only then updating groupIndex.