Skip to content

Fix invalid metadata #4422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Fix invalid metadata #4422

merged 1 commit into from
Mar 10, 2025

Conversation

aleksandar9999a
Copy link
Contributor

Summary

  • When the metadata has the tag "iTunSMPB" or "iTunNORM" then the metadata is not converted correctly and comes [nil, nil, ...] which leads to crash.

Motivation

  • Our team use this library for our app and it is important to prevent crash.

Changes

  • I changed the code so that when merging the metadata, it handles nil or duplicate values. This doesn't add support for the tags in question, but at least it doesn't crash.

Test plan

  • Play link which has tags Itunsmpb и Itunnorm. Sorry, but I can't give you a sample link because ours are private.

Fix invalid metadata
dd4a003 
- When the metadata has the tag "iTunSMPB" or "iTunNORM" then the metadata is not converted correctly and comes [nil, nil, ...] which leads to crash
@freeboub freeboub merged commit bc533e5 into TheWidlarzGroup:master Mar 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub freeboub approved these changes

@KrzysztofMoch KrzysztofMoch Awaiting requested review from KrzysztofMoch

Assignees
No one assigned
Labels
None yet
Projects
React Native Video - Public Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksandar9999a @freeboub