fix(iOS): Allow audio mixing if one of the video views require it #4559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to To Triage
in React Native Video - Public Roadmap
github-project-automation
bot
moved this from To Triage
to Done
in React Native Video - Public Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After the PR #4466, where the AudioSessionManager was introduced, background video audio would be stopped by external apps i.e. Spotify even if mixWithOthers is set to "mix".
Motivation
The video audio should not be paused by external apps if mixWithOthers is set to "mix" or "duck".
Changes
Check if one of the video views has mixWithOthers set to "mix" or "duck" and allow audio mixing.
Test plan
Start playing react-native-video, put the react-native-video app to background, open Spotify, start playing music. Spotify music should mix with react-native-video.