feat(ios): Support for external subtitles on HLS streaming #4577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to To Triage
in React Native Video - Public Roadmap
KrzysztofMoch
moved this from To Triage
to In Review
in React Native Video - Public Roadmap
KrzysztofMoch
requested changes
Jul 9, 2025
There was a problem hiding this comment.
Hey, Thank you for your PR!
"Logic" part of this is looking good to me. But I think it's too "intrusive" - I don't like creating PlayerItem just for this feature (as it does not follow convention of codebase). I would create new class for AVAssetResourceLoaderDelegate and some "Utils" class for rest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Created a delegate to replace the m3u8 file and add in external subtitle url so that they can be played with the video.
Fixes #1511
Motivation
Allows the use of external subtitles. May also be extended to change the timings of subtitles