Update "Resolves a retain cycle and memory leak involving the RCTVideo instance when using Google IMA ads in react-native-video." #4621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update #4574
iOS Google IMA Ads Container Not Resizing on Fullscreen or Rotation — Fixed by Adding AutoresizingMask
After recent changes to Google IMA integration, the ad container on iOS was not resizing when the player entered/exited fullscreen or changed orientation when using custom controls.
Cause:
The adContainerView added inside requestAds() had a fixed frame without autoresizingMask, causing layout issues.
Fix:
Added:
adContainerView.autoresizingMask = [.flexibleWidth, .flexibleHeight]
let adContainerView = UIView(frame: _video.bounds)
adContainerView.backgroundColor = .clear
adContainerView.autoresizingMask = [.flexibleWidth, .flexibleHeight]
_video.addSubview(adContainerView)