Add pictureInPictureResizeMode prop to control scaling in Android PiP (fixes #4655) #4661
+50
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new prop
pictureInPictureResizeModeto control the video scaling in Picture-in-Picture (PiP) mode on Android. This helps prevent white bars when the video aspect ratio does not match the PiP window.Motivation
Previously, videos with an aspect ratio different from the PiP window could display white bars. By introducing
pictureInPictureResizeMode, developers can explicitly set how the video should scale (e.g.,cover,contain,stretch) in PiP mode.Changes
pictureInPictureResizeModeprop in React Native Video.Test plan
pictureInPictureResizeModeprop tocover,contain, orstretch.