fix: handles view not found error gracefully #4788
Merged
+31
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to To Triage
in React Native Video - Public Roadmap
There was a problem hiding this comment.
Pull request overview
This PR improves error handling in the VideoView component to gracefully handle a rare race condition where the native video view is unmounted before the native manager can locate it. Instead of throwing an error, the code now logs a warning when this specific scenario is detected, preventing crashes on slower devices.
Key Changes:
- Enhanced error handling to detect and gracefully handle
view/not-founderrors when the view is quickly mounted and unmounted - Added
VideoComponentErrorto imports for proper error type checking - Added
nitroIdto thesetupViewManagercallback's dependency array
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
github-project-automation
bot
moved this from To Triage
to Done
in React Native Video - Public Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
improves error handling in the
VideoViewcomponent to better handle cases where the native video view is unmounted before the native manager can find it. Instead of throwing an error in this rare scenario, a warning is logged, preventing unnecessary exceptions and improving stability, especially on slower devices.