chore: Upgrade to Nitro 0.35.0#4849
Conversation
KrzysztofMoch
left a comment
There was a problem hiding this comment.
Also, I removed the nitrogen and react-native-nitro-modules patches since I don't think they are necessary anymore. The boolean/number thing in Swift has been fixed upstream, and the exception handling is fixed in react-native core :)
I agree. latest React Native is already 0.84, so it shoud be safe to remove that.
*1: Shouldn't duration be a number (double)? Right now, it can't have commas. It's documented as "The duration of the video in seconds.", and seconds definitely has commas.
Yes, nice find — we need to change it to ms or leave as it is and change type to a number.
|
I think seconds is good, and double. I do the same in VisionCamera |
moskalakamil
left a comment
There was a problem hiding this comment.
LGTM! thanks a lot @mrousavy @KrzysztofMoch and @fnwk. last thing - docs, could you @fnwk please update requirements?
|
Could you release package with this commit included? |
|
Building with this PR causes a build error on android:
This can be fixed by da91f4f (i pushed it in my branch #4724) |
Upgrades to Nitro 0.35.0, which contains a BREAKING CHANGE related to Kotlin HybridObjects (it fixes a critical memory leak, so it is advised everyone upgrades)
Steps I did (you can follow):
bigintwithInt64/UInt64(in this repo;durationandfileSize*1)bun nitrogencpp-adapter.cppcall frominitialize(vm)withregisterAllNatives()- this just allows you to register custom JNI natives in your libs, if needed.Also, I removed the nitrogen and react-native-nitro-modules patches since I don't think they are necessary anymore. The boolean/number thing in Swift has been fixed upstream, and the exception handling is fixed in react-native core :)
durationbe anumber(double)? Right now, it can't have commas. It's documented as "The duration of the video in seconds.", and seconds definitely has commas.