Benchmark update #16
Open
Benchmark update #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheWisp
reviewed
Mar 20, 2020
| @@ -132,7 +132,7 @@ | |||
| <EnableModules>false</EnableModules> | |||
| <IntrinsicFunctions>true</IntrinsicFunctions> | |||
| <OmitFramePointers>false</OmitFramePointers> | |||
| <AdditionalIncludeDirectories>C:\boost_1_71_0;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories> | |||
| <AdditionalIncludeDirectories>C:\boost_1_71_0;C:\Projects\signal-slot-benchmarks\benchmark\lib\iscool\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories> | |||
There was a problem hiding this comment.
Same here, I have copied upstream's file. I will push a fixed version but I can't test it.
TheWisp
reviewed
Mar 20, 2020
| @@ -237,7 +237,7 @@ | |||
| <ClInclude Include="..\benchmark\hpp\benchmark_css.hpp" /> | |||
| <ClInclude Include="..\benchmark\hpp\benchmark_dob.hpp" /> | |||
| <ClInclude Include="..\benchmark\hpp\benchmark_evl.hpp" /> | |||
| <ClInclude Include="..\benchmark\hpp\benchmark_fts.hpp" /> | |||
There was a problem hiding this comment.
I just copied the file from upstream. I fix it.
j-jorge
force-pushed
the
benchmark-update
branch
from
486a1b9 to
deefebb
Compare
This is expected by the benchmark and done with the other libraries. The comparison seems more fair with that.
j-jorge
force-pushed
the
benchmark-update
branch
from
deefebb to
e0782ce
Compare
|
I have updated the branch with the fixes you requested. I cannot test them since I do not use Visual Studio. Hope it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.