Skip to content

Silence one of the duplicated "Loading" messages from run_dev() #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

howardbaik
Copy link
Contributor

@howardbaik howardbaik commented May 6, 2025

In pkgload_load_all(), I set the default value of quiet to TRUE to suppress the output from pkgload::load_all().

This change addresses #1191.

@ColinFay
Copy link
Member

ColinFay commented May 6, 2025

Thanks a lot @howardbaik 🙏

I wasn't aware of this param for pkgload::load_all()

I've cherry-picked your commit in a new branch that is here (you'll still see the commit) : #1201)

I've moved things around a bit — I prefer that the pkgload_load_all function stays with the default param (if ever we need to call it again at some point), and change the param inside document_and_reload.

In case you were wondering, the function in bootsrap_* are a copycat of the default functions, with just a check that the package is installed.

I've also bump the version number and added an entry in the NEWS.

Thanks again.

@ColinFay ColinFay closed this May 6, 2025
@howardbaik
Copy link
Contributor Author

I’m really glad I could contribute—thanks so much for all your work on golem. It’s been an absolute lifesaver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants