#2304 Utilize ConcurrentQueue<T> for managing service versions during polling by the PollKube discovery provider
#2335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raman-m
added
bug
Member
Author
|
@pietrocarpinacci-dufercodev Please review! |
Collaborator
raman-m
commented
Nov 11, 2025
Member
Author
raman-m
left a comment
raman-m
left a comment
There was a problem hiding this comment.
Ready for delivery ✅
- Code reviews ➖
- Unit testing ✔️
- Acceptance testing ✔️
- Updating docs ➖ not required due to the bug
tintoy
reviewed
Nov 11, 2025
Collaborator
tintoy
left a comment
tintoy
left a comment
There was a problem hiding this comment.
Nice idea; looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2304
The problem happened with the first cold request, which returned an empty collection for the winning thread before the initial callback trigger kicked in. The fix simply calls the integrated discovery provider for the first cold request when the queue is empty.
Proposed Changes
PollKubeprovider design to useConcurrentQueue<T>to handle service versions while polling