Skip to content

Set explicit state to a field to improve hackability #8894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Set explicit state to a field to improve hackability #8894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/ui/AdvancedSearch.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
title: $:/AdvancedSearch
icon: $:/core/images/advanced-search-button
color: #bbb
explicitState: $:/state/tab--1498284803

\whitespace trim
<div class="tc-advanced-search">
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/AdvancedSearch]!has[draft.of]]" default="$:/core/ui/AdvancedSearch/System" actions="""<$action-setfield $tiddler="$:/state/advancedsearch/currentTab" text=<<currentTab>>/>""" explicitState="$:/state/tab--1498284803"/>
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/AdvancedSearch]!has[draft.of]]" default="$:/core/ui/AdvancedSearch/System" actions="""<$action-setfield $tiddler="$:/state/advancedsearch/currentTab" text=<<currentTab>>/>""" explicitState={{!!explicitState}}/>
</div>
3 changes: 2 additions & 1 deletion core/ui/AdvancedSearch/Standard.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
title: $:/core/ui/AdvancedSearch/Standard
tags: $:/tags/AdvancedSearch
caption: {{$:/language/Search/Standard/Caption}}
explicitState: $:/state/tab/search-results/advancedsearch

\procedure lingo-base() $:/language/Search/
\procedure set-next-input-tab() <$transclude $variable="change-input-tab" stateTitle="$:/state/tab--1498284803" tag="$:/tags/AdvancedSearch" beforeafter="after" defaultState="$:/core/ui/AdvancedSearch/System" actions="<$action-setfield $tiddler='$:/state/advancedsearch/currentTab' text=<<nextTab>>/>"/>
Expand Down Expand Up @@ -69,7 +70,7 @@ caption: {{$:/language/Search/Standard/Caption}}
tabsList="[all[shadows+tiddlers]tag[$:/tags/SearchResults]!has[draft.of]]"
default={{$:/config/SearchResults/Default}}
actions="<$action-setfield $tiddler='$:/state/advancedsearch/standard/currentTab' text=<<currentTab>>/>"
explicitState="$:/state/tab/search-results/advancedsearch" />
explicitState={{!!explicitState}} />
</$list>
</$vars>
</$list>
Expand Down
3 changes: 2 additions & 1 deletion core/ui/ControlPanel.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
title: $:/ControlPanel
icon: $:/core/images/options-button
color: #bbb
explicitState: $:/state/tab-1749438307

\whitespace trim
<div class="tc-control-panel">
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel]!has[draft.of]]" default="$:/core/ui/ControlPanel/Info" explicitState="$:/state/tab-1749438307"/>
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel]!has[draft.of]]" default="$:/core/ui/ControlPanel/Info" explicitState={{!!explicitState}}/>
</div>
3 changes: 2 additions & 1 deletion core/ui/ControlPanel/Advanced.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
title: $:/core/ui/ControlPanel/Advanced
tags: $:/tags/ControlPanel/Info
caption: {{$:/language/ControlPanel/Advanced/Caption}}
explicitState: $:/state/tab--959111941

\whitespace trim
{{$:/language/ControlPanel/Advanced/Hint}}

<div class="tc-control-panel">
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel/Advanced]!has[draft.of]]" default="$:/core/ui/ControlPanel/TiddlerFields" explicitState="$:/state/tab--959111941"/>
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel/Advanced]!has[draft.of]]" default="$:/core/ui/ControlPanel/TiddlerFields" explicitState={{!!explicitState}}/>
</div>
3 changes: 2 additions & 1 deletion core/ui/ControlPanel/Appearance.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
title: $:/core/ui/ControlPanel/Appearance
tags: $:/tags/ControlPanel
caption: {{$:/language/ControlPanel/Appearance/Caption}}
explicitState: $:/state/tab--1963855381

\whitespace trim
{{$:/language/ControlPanel/Appearance/Hint}}

<div class="tc-control-panel">
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel/Appearance]!has[draft.of]]" default="$:/core/ui/ControlPanel/Theme" explicitState="$:/state/tab--1963855381"/>
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel/Appearance]!has[draft.of]]" default="$:/core/ui/ControlPanel/Theme" explicitState={{!!explicitState}}/>
</div>
3 changes: 2 additions & 1 deletion core/ui/ControlPanel/Info.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
title: $:/core/ui/ControlPanel/Info
tags: $:/tags/ControlPanel
caption: {{$:/language/ControlPanel/Info/Caption}}
explicitState: $:/state/tab--2112689675

\whitespace trim
{{$:/language/ControlPanel/Info/Hint}}

<div class="tc-control-panel">
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel/Info]!has[draft.of]]" default="$:/core/ui/ControlPanel/Basics" explicitState="$:/state/tab--2112689675"/>
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel/Info]!has[draft.of]]" default="$:/core/ui/ControlPanel/Basics" explicitState={{!!explicitState}}/>
</div>
3 changes: 2 additions & 1 deletion core/ui/ControlPanel/Plugins.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
title: $:/core/ui/ControlPanel/Plugins
tags: $:/tags/ControlPanel
caption: {{$:/language/ControlPanel/Plugins/Caption}}
explicitState: $:/state/tab--86143343

\define lingo-base() $:/language/ControlPanel/Plugins/

Expand All @@ -17,4 +18,4 @@ caption: {{$:/language/ControlPanel/Plugins/Caption}}

<<lingo Installed/Hint>>

<$macrocall $name="tabs" tabsList="[all[tiddlers+shadows]tag[$:/tags/ControlPanel/Plugins]!has[draft.of]]" default="$:/core/ui/ControlPanel/Plugins/Installed/Plugins" explicitState="$:/state/tab--86143343"/>
<$macrocall $name="tabs" tabsList="[all[tiddlers+shadows]tag[$:/tags/ControlPanel/Plugins]!has[draft.of]]" default="$:/core/ui/ControlPanel/Plugins/Installed/Plugins" explicitState={{!!explicitState}}/>
3 changes: 2 additions & 1 deletion core/ui/ControlPanel/Saving.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
title: $:/core/ui/ControlPanel/Saving
tags: $:/tags/ControlPanel
caption: {{$:/language/ControlPanel/Saving/Caption}}
explicitState: $:/state/tab-2065006209

\whitespace trim
{{$:/language/ControlPanel/Saving/Hint}}

<div class="tc-control-panel">
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel/Saving]!has[draft.of]]" default="$:/core/ui/ControlPanel/Saving/General" explicitState="$:/state/tab-2065006209"/>
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel/Saving]!has[draft.of]]" default="$:/core/ui/ControlPanel/Saving/General" explicitState={{!!explicitState}}/>
</div>
3 changes: 2 additions & 1 deletion core/ui/ControlPanel/Settings.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
title: $:/core/ui/ControlPanel/Settings
tags: $:/tags/ControlPanel
caption: {{$:/language/ControlPanel/Settings/Caption}}
explicitState: $:/state/tab--697582678

<div class="tc-control-panel">
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel/SettingsTab]!has[draft.of]]" default="$:/core/ui/ControlPanel/Settings/TiddlyWiki" explicitState="$:/state/tab--697582678"/>
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel/SettingsTab]!has[draft.of]]" default="$:/core/ui/ControlPanel/Settings/TiddlyWiki" explicitState={{!!explicitState}}/>
</div>
3 changes: 2 additions & 1 deletion core/ui/ControlPanel/Toolbars.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
title: $:/core/ui/ControlPanel/Toolbars
tags: $:/tags/ControlPanel/Appearance
caption: {{$:/language/ControlPanel/Toolbars/Caption}}
explicitState: $:/state/tabs/controlpanel/toolbars-1345989671

\whitespace trim
{{$:/language/ControlPanel/Toolbars/Hint}}

<div class="tc-control-panel">
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel/Toolbars]!has[draft.of]]" default="$:/core/ui/ControlPanel/Toolbars/ViewToolbar" class="tc-vertical" explicitState="$:/state/tabs/controlpanel/toolbars-1345989671"/>
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/ControlPanel/Toolbars]!has[draft.of]]" default="$:/core/ui/ControlPanel/Toolbars/ViewToolbar" class="tc-vertical" explicitState={{!!explicitState}}/>
</div>
4 changes: 2 additions & 2 deletions core/ui/MoreSideBar/Plugins.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
title: $:/core/ui/MoreSideBar/Plugins
tags: $:/tags/MoreSideBar
caption: {{$:/language/ControlPanel/Plugins/Caption}}

explicitState: $:/state/tab-1163638994

{{$:/language/ControlPanel/Plugins/Installed/Hint}}

<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/MoreSideBar/Plugins]!has[draft.of]]" default="$:/core/ui/MoreSideBar/Plugins/Plugins" explicitState="$:/state/tab-1163638994"/>
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/MoreSideBar/Plugins]!has[draft.of]]" default="$:/core/ui/MoreSideBar/Plugins/Plugins" explicitState={{!!explicitState}}/>
3 changes: 2 additions & 1 deletion core/ui/SearchResults.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
title: $:/core/ui/SearchResults
explicitState: $:/state/tab/search-results/sidebar

<div class="tc-search-results">

Expand All @@ -10,7 +11,7 @@ title: $:/core/ui/SearchResults
tabsList="[all[shadows+tiddlers]tag[$:/tags/SearchResults]!has[draft.of]]"
default={{$:/config/SearchResults/Default}}
actions="<$action-setfield $tiddler='$:/state/search/currentTab' text=<<currentTab>>/>"
explicitState="$:/state/tab/search-results/sidebar"/>
explicitState={{!!explicitState}}/>

</$list>

Expand Down
3 changes: 2 additions & 1 deletion core/ui/SideBar/More.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
title: $:/core/ui/SideBar/More
tags: $:/tags/SideBar
caption: {{$:/language/SideBar/More/Caption}}
explicitState: $:/state/tab/moresidebar-1850697562

\whitespace trim
<div class={{{ [{$:/config/ui/SideBar/More/horizontal}match[yes]then[tc-sidebar-tabs]else[tc-more-sidebar]] }}}>
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/MoreSideBar]!has[draft.of]]" default={{$:/config/DefaultMoreSidebarTab}} state="$:/state/tab/moresidebar" class={{{ [{$:/config/ui/SideBar/More/horizontal}match[yes]then[tc-sidebar-tabs-more]else[tc-vertical tc-sidebar-tabs-more]] }}} explicitState="$:/state/tab/moresidebar-1850697562"/>
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/MoreSideBar]!has[draft.of]]" default={{$:/config/DefaultMoreSidebarTab}} state="$:/state/tab/moresidebar" class={{{ [{$:/config/ui/SideBar/More/horizontal}match[yes]then[tc-sidebar-tabs-more]else[tc-vertical tc-sidebar-tabs-more]] }}} explicitState={{!!explicitState}}/>
</div>
3 changes: 2 additions & 1 deletion core/ui/SideBarSegments/tabs.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
title: $:/core/ui/SideBarSegments/tabs
tags: $:/tags/SideBarSegment
explicitState: $:/state/tab/sidebar--595412856

<div class="tc-sidebar-lists tc-sidebar-tabs" role="region" aria-label={{$:/language/SideBar/Caption}}>

<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/SideBar]!has[draft.of]]" default={{$:/config/DefaultSidebarTab}} state="$:/state/tab/sidebar" class="tc-sidebar-tabs-main" explicitState="$:/state/tab/sidebar--595412856"/>
<$macrocall $name="tabs" tabsList="[all[shadows+tiddlers]tag[$:/tags/SideBar]!has[draft.of]]" default={{$:/config/DefaultSidebarTab}} state="$:/state/tab/sidebar" class="tc-sidebar-tabs-main" explicitState={{!!explicitState}}/>

</div>
Loading