Get-file web server route now support streaming #9078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: linonetwo has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2527.2 KB |
| PR | 2528.5 KB |
Diff: ⬆️ Increase: +1.3 KB
Jermolene
reviewed
Jun 9, 2025
| status = 404; | ||
| content = "File '" + suppliedFilename + "' not found"; | ||
| if(path.relative(baseFilename,filename).indexOf("..") === 0) { | ||
| return state.sendResponse(403,{"Content-Type": "text/plain"},"Access denied"); |
There was a problem hiding this comment.
Sending a 403 response is not a backwards compatible change. In general I think we should prefer 404 because 403 is apt to reveal information about the existence of resources.
There was a problem hiding this comment.
Okay, I also update the put-file for this. Consistent behavior across GET/PUT routes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support video Range HTTP header and straming large file. I've tested it, now video in ./files folder can be loaded partially with 206 Partial Content, also allow downloader to resume download things.
This will add more code to the core, so I make it a separate PR incase you don't like it. I currently only need #9075 , and this PR is only a byproduct.
I'm not sure how we could add test for server route. I test this manually with agent like this: