Adds an images filter #9095
Draft
Adds an images filter #9095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed: saqimtiaz has already signed the Contributor License Agreement (see contributing.md) |
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2528.0 KB |
| PR | 2529.4 KB |
Diff: ⬆️ Increase: +1.4 KB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an images filter that returns all images used in a tiddler using an
$imagewidget or the[img[...]]syntax.It introduces a new
wiki.extractFromParseTreemethod that is now used byextractImages,extractLinksandextractTranscludes.Transclusions of image tiddlers are not picked up by the filter, neither are
<img>HTML elements, as is consistent with thelinks[]operator which only returns links created by the$linkwidget.There may however be value in supporting the extraction of
<img>HTML elements as well, possibly enabled by a suffix. Any thoughts on this are welcome.To do: