Refactors widget attribute and refresh handling #9101
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed: saqimtiaz has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2528.0 KB |
| PR | 2529.4 KB |
Diff: ⬆️ Increase: +1.4 KB
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pmario
reviewed
Jun 17, 2025
saqimtiaz
force-pushed
the
imagewidget-refresh
branch
from
7ace65f to
2bb7c79
Compare
saqimtiaz
force-pushed
the
imagewidget-refresh
branch
from
48cafd3 to
a7434b1
Compare
saqimtiaz
force-pushed
the
imagewidget-refresh
branch
from
41260fc to
9d39db7
Compare
pmario
reviewed
Jun 23, 2025
saqimtiaz
force-pushed
the
imagewidget-refresh
branch
2 times, most recently
from
089c17f to
5069cc6
Compare
|
@pmario could you please attempt to engage with the substance of the PR, rather than serving as a syntax checker? The latter is of absolutely no value on a PR clearly described as exploratory and in draft status, whereas actual feedback on the changes explored here would be very helpful. |
saqimtiaz
force-pushed
the
imagewidget-refresh
branch
from
5069cc6 to
a13279a
Compare
saqimtiaz
force-pushed
the
imagewidget-refresh
branch
2 times, most recently
from
e08e7bd to
205293b
Compare
saqimtiaz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress:
This is an exploratory PR to see if a refactor of the base widget class that changes how we calculate and refresh attributes towards a more declarative style can be made while staying backwards compatible.
data-andstyle.attributes for the image widget, correcting an omission in Add data attribute support to button and other widgets #7769assignAttributeswhich allows it to accept an additional hashmap (additionalAttributesMap) of mappings from widget attributes to DOM attributes. This can be used to simplify both the assignment of DOM attributes as well as their refresh.