Skip to content

Use s instead of strike #9131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Leilei332
Copy link
Contributor

Closes #8922

Since this isn't backward compatible, this PR targets v5.4.0.

Copy link

netlify bot commented Jul 7, 2025

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit ba55bb8
🔍 Latest deploy log https://app.netlify.com/projects/tiddlywiki-previews/deploys/686ca74d6d24a4000823d70d
😎 Deploy Preview https://deploy-preview-9131--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Jul 7, 2025

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

Copy link

github-actions bot commented Jul 7, 2025

📊 Build Size Comparison: empty.html

Branch Size
Base (master) 2537.6 KB
PR 2537.5 KB

Diff: ⬇️ Decrease: 0.0 KB

@pmario
Copy link
Member

pmario commented Jul 7, 2025

@Jermolene ... It looks good. -- Tests have passed. So we do not seem to test for it.

image

@pmario
Copy link
Member

pmario commented Jul 7, 2025

@Leilei332 -- We also need to change this documentation tiddler https://tiddlywiki.com/#Formatting%20in%20WikiText

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IDEA] Render wikitext strikethrough as <s> instead of <strike>
2 participants