[5.4.0] Update eslint target to 2017 and do initial fixes #9135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: Arlen22 has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2537.6 KB |
| PR | 2537.6 KB |
Diff: ⬆️ Increase: +0.0 KB
|
@Jermolene this should only be merged if it targets the latest commit (should be 2137444).
|
pmario
reviewed
Jul 8, 2025
Arlen22
force-pushed
the
es2017/eslint-fixes-self-es2017
branch
from
371e851 to
2137444
Compare
github-project-automation
bot
moved this from Resolve first
to Done
in Planning for v5.4.0
|
@Arlen22 -- Why did you close the PR? |
- update eslint to 2017 - add self to forbidden globals - fix a few unfixable bugs caught by eslint - convert newer features in twitter-archivist
|
Confirmed: Arlen22 has already signed the Contributor License Agreement (see contributing.md) |
|
@Jermolene to make it easier to merge this in, I removed the automated fixes, since you can just as easily run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the eslint target to 2017 and does a first pass on basic fixes.
I tried to break each action into separate commits. Inspect the diff of each commit.