eslint rules experiments for es2017 #9136
Conversation
- update eslint to 2017 - add self to forbidden globals - fix a few unfixable bugs caught by eslint - convert newer features in twitter-archivist
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: Arlen22 has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2537.6 KB |
| PR | 2534.8 KB |
Diff: ⬇️ Decrease: 2.8 KB
Arlen22
force-pushed
the
es2017/eslint-recommended
branch
from
d18456d to
2e97a69
Compare
Arlen22
changed the title
Arlen22
force-pushed
the
es2017/eslint-recommended
branch
4 times, most recently
from
6f1715b to
3835e8b
Compare
Arlen22
force-pushed
the
es2017/eslint-recommended
branch
from
3835e8b to
9551969
Compare
Well, converting from string concatenation to template strings saves 5 KB.
Only doing the recommended fixes without any additional rules.
Adding the default Typescript formatter with spaces around operators and removing semicolons
Same settings but with semicolons explicitly inserted.
And with the rest of the automated changes, like arrow functions, const declarations, etc. |
Arlen22
force-pushed
the
es2017/eslint-recommended
branch
4 times, most recently
from
e543441 to
70f7c9c
Compare
Arlen22
force-pushed
the
es2017/eslint-recommended
branch
from
70f7c9c to
9940c09
Compare
|
You did go down the rabbit hole. Interesting. Did you have a closer look at boot.js? It seems to be completely messed up. It seems it did "sort" the exported functions. IMO it should not do that. The diff is completely unreadable. I do like the template strings. |
|
The biggest problem I do have is the enormous amount of devdependencies that are included. |
|
I'm not sure if the typescript related rules are required. I might be able to get away with removing that. I hadn't noticed the sorting but that can be disabled. |
I'm mostly just playing around with seeing how many eslint rules I can find that automatically upgrade to newer syntaxes and the PR is mostly to see how the size changes.