Skip to content

Conversation

@pmario
Copy link
Member

@pmario pmario commented Aug 2, 2025

This PR fixes #7700

It implements the changes suggested by @ericshulman at the issue.

The functionality is not 100% perfect (see discussion at the issue), but it is a usable improvement.

@github-actions
Copy link

github-actions bot commented Aug 2, 2025

Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md)

@github-actions
Copy link

github-actions bot commented Aug 2, 2025

📊 Build Size Comparison: empty.html

Branch Size
Base (master) 2537.6 KB
PR 2538.8 KB

Diff: ⬆️ Increase: +1.2 KB

@netlify
Copy link

netlify bot commented Aug 2, 2025

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit 7a2d92f
🔍 Latest deploy log https://app.netlify.com/projects/tiddlywiki-previews/deploys/688e33e9e7ac450008f7ad15
😎 Deploy Preview https://deploy-preview-9214--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pmario pmario added the needswork PR that cannot yet be merged; Issue that is "almost" actionable label Dec 15, 2025
@netlify
Copy link

netlify bot commented Jan 25, 2026

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit 7f7e309
🔍 Latest deploy log https://app.netlify.com/projects/tiddlywiki-previews/deploys/697663f8956b5100089f7791
😎 Deploy Preview https://deploy-preview-9214--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Jan 25, 2026

📊 Build Size Comparison: empty.html

Branch Size
Base (master) 2448.3 KB
PR 2449.4 KB

Diff: ⬆️ Increase: +1.2 KB


✅ Change Note Status

All change notes are properly formatted and validated!

📝 $:/changenotes/5.4.0/#9214

Type: bugfix | Category: usability
Release: 5.4.0

Allow title, tags, text as initial focus for editing existing tiddlers

🔗 #9214

👥 Contributors: pmario


📖 Change Note Guidelines

Change notes help track and communicate changes effectively. See the full documentation for details.

@pmario pmario added bug Confirmed, replicable bug and removed needswork PR that cannot yet be merged; Issue that is "almost" actionable labels Jan 25, 2026
@pmario pmario removed the bug Confirmed, replicable bug label Jan 25, 2026
@pmario
Copy link
Member Author

pmario commented Jan 25, 2026

@saqimtiaz ... This is ready for review

@ericshulman ... Can you please check it?

@saqimtiaz
Copy link
Member

The functionality is not 100% perfect

Could you please summarize the current status of any remaining issues with the implementation?

@pmario
Copy link
Member Author

pmario commented Jan 25, 2026

The functionality is not 100% perfect

Could you please summarize the current status of any remaining issues with the implementation?

Sorry for the cryptic comment.


About: Not 100% perfect ... is my personal opinion about the workflow.

I am not happy, if the "text" field is active when the tiddler is opened. It selects the whole text. So if the user accidentally hits a button, the whole text is deleted.

I did some experiments with "unselected" text and only showing the "cursor" at the beginning or at the end of the text field. -- But that's also not perfect, since the cursor is almost invisible.

So whatever we do in my opinion it's not perfect - but good enough ;)

@pmario
Copy link
Member Author

pmario commented Jan 25, 2026

@saqimtiaz I did just give some feedback. see: #9214 (comment) -- Do you need more?

@saqimtiaz
Copy link
Member

@pmario thank you for that summary. I think we need input from Jeremy on the usability aspect of these changes, so I have added it to the list for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs feedback

Development

Successfully merging this pull request may close these issues.

[IDEA] Focus textarea/content after clicking "Edit this tiddler"

4 participants