-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Allow title, tags, text as focus for editing existing tiddlers #9214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2537.6 KB |
| PR | 2538.8 KB |
Diff: ⬆️ Increase: +1.2 KB
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2448.3 KB |
| PR | 2449.4 KB |
Diff: ⬆️ Increase: +1.2 KB
✅ Change Note Status
All change notes are properly formatted and validated!
📝 $:/changenotes/5.4.0/#9214
Type: bugfix | Category: usability
Release: 5.4.0
Allow title, tags, text as initial focus for editing existing tiddlers
🔗 #9214
👥 Contributors: pmario
📖 Change Note Guidelines
Change notes help track and communicate changes effectively. See the full documentation for details.
|
@saqimtiaz ... This is ready for review @ericshulman ... Can you please check it? |
Could you please summarize the current status of any remaining issues with the implementation? |
Sorry for the cryptic comment.
About: Not 100% perfect ... is my personal opinion about the workflow. I am not happy, if the "text" field is active when the tiddler is opened. It selects the whole text. So if the user accidentally hits a button, the whole text is deleted. I did some experiments with "unselected" text and only showing the "cursor" at the beginning or at the end of the text field. -- But that's also not perfect, since the cursor is almost invisible. So whatever we do in my opinion it's not perfect - but good enough ;) |
|
@saqimtiaz I did just give some feedback. see: #9214 (comment) -- Do you need more? |
|
@pmario thank you for that summary. I think we need input from Jeremy on the usability aspect of these changes, so I have added it to the list for review. |
This PR fixes #7700
It implements the changes suggested by @ericshulman at the issue.
The functionality is not 100% perfect (see discussion at the issue), but it is a usable improvement.