Skip to content

Conversation

Leilei332
Copy link
Contributor

Copy link

netlify bot commented Aug 19, 2025

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit 18a3019
🔍 Latest deploy log https://app.netlify.com/projects/tiddlywiki-previews/deploys/68a6c1ba97726700085497c5
😎 Deploy Preview https://deploy-preview-9266--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

@Leilei332 Leilei332 marked this pull request as draft August 19, 2025 03:37
@pmario
Copy link
Member

pmario commented Aug 19, 2025

I think the problem here is, that my browser language does not match my native language. I use an English OS and browser setting, but I still may want to download a German enmpty edition.

I think the browser settings can be a starting point and it may fit for 80% of the users, but there needs to be a selector.

"Smart" software can make a suggestion based on some heuristics, but the final decision has to made by the user.

@Leilei332
Copy link
Contributor Author

This PR now uses a language selector button, a browser startup action is created to change the selected language to browser language settings.

image

@Jermolene
Copy link
Member

Thanks @Leilei332 those are good improvements. The approach still rests on the accuracy of the users browser language setting. It would be useful to have a better idea of how many users like @pmario have their browser language not set to their native language. I would guess it would be a small minority of <10%, but I'd prefer to have some data.

@pmario
Copy link
Member

pmario commented Aug 20, 2025

It would be useful to have a better idea of how many users like @pmario have their browser language not set to their native language. I would guess it would be a small minority of <10%, but I'd prefer to have some data.

@Jermolene ... I think defaulting the selection to the browser defaults at startup is OK. Even for users like me.

I do have some custom language settings for a reason. So I do expect inconsistent behaviour, depending on the program I start. Eg: My office software is German. The OS and browser is set to English.


@Leilei332 -- If en-GB is selected there should also be some text eg: "English (British) is the default setting here. So click the "Download" button above.

Or something similar.

grafik

May be we should also link to the Full Edition tiddler, that should provide some more info about all possible languages.

@pmario
Copy link
Member

pmario commented Aug 20, 2025

Or may be we add the "English - British" info directly to the text before the Download button

grafik

@Leilei332
Copy link
Contributor Author

This PR now displays links to guides for creating new translations if browser's language is not supported by tiddlywiki.

Screenshot_20250821-145933.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants