Add an option to disable CORS #9277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: kixam has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2537.6 KB |
| PR | 2538.2 KB |
Diff: ⬆️ Increase: +0.6 KB
|
Thank you @kixam, that makes a lot of sense, and I would like to include this in v5.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider adding an option to the TiddlyWiki5 server that disables CORS (ie. don't check same-origin).
Typical scenario is : from local TW5 file, use both a saver eg. TiddlyFox, AND a syncer eg. a modified TiddlyWeb, that syncs to a TiddlyWiki5 server, that is either on the local machine, or only accessible through a secure VPN.
FYI, the GitLab saver can be used "as is" from a local TW5 file (I verified that by modifying the saver mechanism to allow two savers to proceed instead of just one), so they must have disabled CORS in their default configuration. I suppose they trust their authentication system. TiddlyWiki server authentication seems rather weak for now, that is why i would not expose the server directly to the Internet in its current state.
The use of a proxy server was discussed do handle CORS, and I suppose it could be used to authenticate as well, but I would rather use a simpler solution for my use case.