Skip to content

Intergrate tiddlywiki palette colors and settings to custom CSS properties #9333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Intergrate tiddlywiki palette colors and settings to custom CSS properties #9333

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1e86e13
Expose tiddlywiki palette colors and settings to custom CSS properties
Leilei332 Oct 11, 2025
6592c07
Rename & use --tc prefix
Leilei332 Oct 12, 2025
48c9f03
Add colors and CSS settings
Leilei332 Oct 12, 2025
73bb30c
Make CSS settings properties' name readable
Leilei332 Oct 12, 2025
0dd151f
Add all CSS settings
Leilei332 Oct 12, 2025
9a628a4
Add all palette colors
Leilei332 Oct 17, 2025
5b41130
Remove macrocallblock rule
Leilei332 Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions core/stylesheets/custom-properties.tid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
title: $:/core/stylesheets/custom-properties
tags: [[$:/tags/Stylesheet]]
list-before:

\rules only transcludeinline macrocallinline macrocallblock

/* Tiddlywiki's CSS properties */

:root {
--tc-alert-background: <<colour alert-background>>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tc- prefix is used for TW class names. So IMO it will be confusing if we use it for CSS variables too.

tv- is used for TW variables. So imo --tv- can be used for CSS variables. This would be more consistent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually c stands for color here. In custom properties there is no classes, but there exists color data type.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Leilei332 I do think that using tc- is confusing, and we need to adopt a different prefix here. Many appropriate prefixes have already been used (eg tv- which is used for TW system variables).

Perhaps we might introduce a new v- prefix for CSS variable, so you’d have v-alert-background etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Leilei332 I do think that using tc- is confusing, and we need to adopt a different prefix here. Many appropriate prefixes have already been used (eg tv- which is used for TW system variables).

Perhaps we might introduce a new v- prefix for CSS variable, so you’d have v-alert-background etc.

If we don't care about the potential name conflict between CSS settings and palette colors, I think tp- prefix is acceptable. If we do care, we may use tp-c- prefix.

Copy link
Member

@pmario pmario Oct 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think --cc- for CSS color and
--cp- for CSS parameter would be OK and consistent.

It avoids name clashes with user CSS variables, so they do not use any prefix. It's also easy to discuss at Talk. Users may use a shortcut for cc-variables or cp-variables -- It's not correct, but we still will know what is meant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think --cc- for CSS color and
--cp- for CSS parameter would be OK and consistent.

It avoids name clashes with user CSS variables, so they do not use any prefix. It's also easy to discuss at Talk. Users may use a shortcut for cc-variables or cp-variables -- It's not correct, but we still will know what is meant.

This isn't acceptable. It can't show that this custom property is only for tiddlywiki.

--tc-alert-border: <<colour alert-border>>;
--tc-alert-highlight: <<colour alert-highlight>>;
--tc-alert-muted-foreground: <<colour alert-muted-foreground>>;
--tc-background: <<colour background>>;
--tc-blockquote-bar: <<colour blockquote-bar>>;
--tc-button-background: <<colour button-background>>;
--tc-button-border: <<colour button-border>>;
--tc-button-foreground: <<colour button-foreground>>;
--tc-code-background: <<colour code-background>>;
--tc-code-border: <<colour code-border>>;
--tc-code-foreground: <<colour code-foreground>>;
--tc-diff-delete-background: <<colour diff-delete-background>>;
--tc-diff-delete-foreground: <<colour diff-delete-foreground>>;
--tc-diff-equal-background: <<colour diff-equal-background>>;
--tc-diff-equal-foreground: <<colour diff-equal-foreground>>;
--tc-diff-insert-background: <<colour diff-insert-background>>;
--tc-diff-insert-foreground: <<colour diff-insert-foreground>>;
--tc-diff-invisible-background: <<colour diff-invisible-background>>;
--tc-diff-invisible-foreground: <<colour diff-invisible-foreground>>;
--tc-dirty-indicator: <<colour dirty-indicator>>;
--tc-download-background: <<colour download-background>>;
--tc-download-foreground: <<colour download-foreground>>;

/* CSS settings */
--tp-codewrapping: {{$:/themes/tiddlywiki/vanilla/options/codewrapping}};
--tp-fontfamily: {{$:/themes/tiddlywiki/vanilla/settings/fontfamily}};
--tp-codefontfamily: {{$:/themes/tiddlywiki/vanilla/settings/codefontfamily}};
--tp-editorfontfamily: {{$:/themes/tiddlywiki/vanilla/settings/editorfontfamily}};
--tp-fontsize: {{$:/themes/tiddlywiki/vanilla/metrics/fontsize}};
--tp-lineheight: {{$:/themes/tiddlywiki/vanilla/metrics/lineheight}};
--tp-bodyfontsize: {{$:/themes/tiddlywiki/vanilla/metrics/bodyfontsize}};
--tp-tiddlerwidth: {{$:/themes/tiddlywiki/vanilla/metrics/tiddlerwidth}}

}