Open
Conversation
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: Arlen22 has already signed the Contributor License Agreement (see contributing.md) |
pmario
requested changes
Oct 11, 2025
7a8f1c4 to
ff5307c
Compare
- trying to find as many uses of plugins as I can
ff5307c to
fdaf9f6
Compare
Leilei332
reviewed
Oct 12, 2025
Arlen22
commented
Dec 17, 2025
Member
Author
|
Add separate change notes for preloadHooks and datatiddlerserializer |
Member
Author
|
@Jermolene is this ready to merge? I think I'm ready. |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2449.5 KB |
| PR | 2591.5 KB |
Diff: ⬆️ Increase: +142.0 KB
✅ Change Note Status
All change notes are properly formatted and validated!
📝 $:/changenotes/5.4.0/#9336
Type: enhancement | Category: developer
Release: 5.4.0
Formalize data tiddlers and add preloadHooks array
🔗 #9336
👥 Contributors: Arlen22
📖 Change Note Guidelines
Change notes help track and communicate changes effectively. See the full documentation for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
This is related to #9068 and #9064.
Breaking Changes: 5.4.0
The major breaking change in this PR is that plugins must now be parsed like this.
and stringified like this
This adds the following methods to $tw.utils
It adds the module-type
datatiddlerserializerwith the following interface.Registered serializers are a hashmap on the
$tw.Wiki.dataTiddlerSerializerModulesstatic property.It registers two data tiddler types
application/json- the usual format that plugins usex-tiddler-dictionary- the format used for things like color palettes.Under the hood both of these are data tiddler formats.
Data tiddler types are rarely interchangeable unless they have an explicitly defined relationship.
A plugin qualifies as a data tiddler, which inspired me to just make it official instead of accounting for all the cases of x-tiddler-dictionary. Of course, x-tiddler-dictionary has additional constraints. It cannot be used for a plugin, as it requires the data to be of type
Record<string, string>(aka a hashmap of strings). But setting the type field is very explicit.