Fix crash when processing large files from tiddlywiki.files #9341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* skip reading file content when _canonical_uri is present * skip loading file when file size is too large
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: cdruan has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2421.1 KB |
| PR | 2421.8 KB |
Diff: ⬆️ Increase: +0.6 KB
pmario
reviewed
Oct 14, 2025
| text = ""; | ||
| } else if(fs.statSync(pathname).size > $tw.config.maxEditFileSize) { | ||
| var msg = "File " + pathname + " not loaded because it is too large"; | ||
| console.log("Warning: " + msg); |
There was a problem hiding this comment.
IMO console.warn() or even console.error() may be used here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip reading file content when
_canonical_uriis presentskip loading file when file size is too large