feat: Allow user scope to view old events #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonatanaatos
force-pushed
the
allow-user-scope-to-view-old-events
branch
from
7202a9f
to
e270915
Compare
joonatanaatos
force-pushed
the
allow-user-scope-to-view-old-events
branch
from
e270915
to
170844c
Compare
PurkkaKoodari
requested changes
Oct 27, 2024
Comment on lines
-214
to
-227
| // and either: | ||
| [Op.or]: { | ||
| // closed less than a week ago | ||
| registrationEndDate: { | ||
| [Op.gt]: moment().subtract(7, "days").toDate(), | ||
| }, | ||
| // or happened less than a week ago | ||
| date: { | ||
| [Op.gt]: moment().subtract(7, "days").toDate(), | ||
| }, | ||
| endDate: { | ||
| [Op.gt]: moment().subtract(7, "days").toDate(), | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I think we'll still want a hard limit for regular users
| @@ -24,8 +24,20 @@ function eventOrder(): Order { | |||
| export const eventsListForUserCached = createCache({ | |||
| maxAgeMs: 1000, | |||
| maxPendingAgeMs: 2000, | |||
| async get(category?: string) { | |||
| const where = category ? { category } : {}; | |||
| async get(options: { category?: string; since?: Date }) { | |||
There was a problem hiding this comment.
This won't work with the current caching system, which compares the function argument with Object.is (using a Map)
| } | ||
| if (since) { | ||
| filters.date = { | ||
| [Op.gt]: since, |
There was a problem hiding this comment.
Op.gte would probably be more exact
Comment on lines
+41
to
+45
| since: Type.Optional( | ||
| Type.Date({ | ||
| description: "If set, only events starting after this date are included.", | ||
| }), | ||
| ), |
There was a problem hiding this comment.
Type.Date is a typebox extension, it doesn't actually parse the dates. You'll need to use Type.String with format: "date-time" and parse yourself (like we do in e.g. updateEvent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.