-
Notifications
You must be signed in to change notification settings - Fork 5
Update Core to 2.28. #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Core to 2.28. #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @teo-tsirpanis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the Core library to version 2.28. The changes involve adding several new methods to the Methods.cs
file within the TileDB.CSharp/Interop
namespace. These new methods provide access to underlying C API functions for statistics, enumerations, array schemas, query fields, and subarrays.
Highlights
- Statistics: Adds
tiledb_stats_is_enabled
to check if statistics are enabled. - Enumerations: Adds
tiledb_enumeration_get_value_index
to retrieve the index of a value within an enumeration. - Array Schemas: Adds
tiledb_array_schema_alloc_at_timestamp
to allocate an array schema at a specific timestamp. - Query Fields: Adds
tiledb_field_get_nullable
to determine if a query field is nullable. - Subarrays: Adds
tiledb_subarray_add_point_ranges_var
to add variable-length point ranges to a subarray. - QueryField.cs: Adds
IsNullable
property to theQueryField
class. - Stats.cs: Adds
IsEnabled
property to theStats
class.
Changelog
- sources/TileDB.CSharp/Interop/Methods.cs
- Added
tiledb_stats_is_enabled
function import. - Added
tiledb_enumeration_get_value_index
function import. - Added
tiledb_array_schema_alloc_at_timestamp
function import. - Added
tiledb_field_get_nullable
function import. - Added
tiledb_subarray_add_point_ranges_var
function import.
- Added
- sources/TileDB.CSharp/QueryField.cs
- Added
IsNullable
property to check if a query field is nullable, using the newly importedtiledb_field_get_nullable
function.
- Added
- sources/TileDB.CSharp/Stats.cs
- Added
IsEnabled
property to check if statistics are enabled, using the newly importedtiledb_stats_is_enabled
function.
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Interop's dance, a bridge we make,
C# calls C, for goodness sake.
New methods bloom,
Dispelling gloom,
Core's update, for progress' wake.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Core to version 2.28, adding new methods to the C# interop layer. The changes look good overall, and the new functionalities seem to be correctly implemented.
Merge Readiness
The pull request appears to be in good shape for merging. All changes seem to be correctly implemented. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. Since there are no critical or high severity issues, the pull request is ready to be merged.
/// Gets whether the <see cref="QueryField"/> is nullable. | ||
/// </summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// </summary> | ||
/// <seealso cref="Enable"/> | ||
/// <seealso cref="Disable"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a brief description of when statistics would be enabled or disabled. This would help users understand the purpose of this property.
/// <summary>
/// Gets whether statistics are enabled.
/// Statistics gathering provides insights into the performance of TileDB operations.
/// </summary>
/// <seealso cref="Enable"/>
/// <seealso cref="Disable"/>
No description provided.