Use Ninja on macOS CI. #5069
Merged
Use Ninja on macOS CI. #5069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
force-pushed
the
teo/macos-14
branch
from
b8f8df6 to
1adc75b
Compare
|
Will run CI on my fork to reduce congestion. |
This was referenced Jun 11, 2024
teo-tsirpanis
force-pushed
the
teo/macos-14
branch
from
12dd827 to
c618d52
Compare
teo-tsirpanis
force-pushed
the
teo/macos-14
branch
from
c618d52 to
396c5ed
Compare
teo-tsirpanis
changed the title
macos-14.
KiterLuc
approved these changes
Jun 13, 2024
|
Merging this so that we reduce contention for macos runners in CI. We'll investigate reverting back with a proper solution if there are objections from the team. |
This was referenced Jun 19, 2024
KiterLuc
pushed a commit
that referenced
this pull request
Jun 19, 2024
[SC-49308](https://app.shortcut.com/tiledb-inc/story/49308/macos-runners-significantly-slower-after-pr-5001) This PR updates all macOS CI jobs to use Ninja instead of makefiles, which was observed to fix unexplained significant performance regressions. Certain other scripts were updated to be generator-agnostic by invoking `cmake --build` instead of `make`. Nightly builds were not updated to keep testing coverage with makefiles, and the standalone unit tests were not updated because their performance has not regressed. --- TYPE: NO_HISTORY
KiterLuc
pushed a commit
that referenced
this pull request
Jun 19, 2024
[SC-49308](https://app.shortcut.com/tiledb-inc/story/49308/macos-runners-significantly-slower-after-pr-5001) This PR updates all macOS CI jobs to use Ninja instead of makefiles, which was observed to fix unexplained significant performance regressions. Certain other scripts were updated to be generator-agnostic by invoking `cmake --build` instead of `make`. Nightly builds were not updated to keep testing coverage with makefiles, and the standalone unit tests were not updated because their performance has not regressed. --- TYPE: NO_HISTORY
KiterLuc
pushed a commit
that referenced
this pull request
Jun 19, 2024
[SC-49308](https://app.shortcut.com/tiledb-inc/story/49308/macos-runners-significantly-slower-after-pr-5001) This PR updates all macOS CI jobs to use Ninja instead of makefiles, which was observed to fix unexplained significant performance regressions. Certain other scripts were updated to be generator-agnostic by invoking `cmake --build` instead of `make`. Nightly builds were not updated to keep testing coverage with makefiles, and the standalone unit tests were not updated because their performance has not regressed. --- TYPE: NO_HISTORY
KiterLuc
added a commit
that referenced
this pull request
Jun 19, 2024
Backport 4d008c0 from #5069. --- TYPE: NO_HISTORY Co-authored-by: Theodore Tsirpanis <[email protected]>
KiterLuc
added a commit
that referenced
this pull request
Jun 19, 2024
Backport 4d008c0 from #5069. --- TYPE: NO_HISTORY Co-authored-by: Theodore Tsirpanis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-49308
This PR updates all macOS CI jobs to use Ninja instead of makefiles, which was observed to fix unexplained significant performance regressions. Certain other scripts were updated to be generator-agnostic by invoking
cmake --buildinstead ofmake.Nightly builds were not updated to keep testing coverage with makefiles, and the standalone unit tests were not updated because their performance has not regressed.
TYPE: NO_HISTORY