[Backport release-2.24] Add temporary mitigations for CI failures in windows-2022. (#5057) #5073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[SC-48975](https://app.shortcut.com/tiledb-inc/story/48975) Visual Studio 2022 17.10 has been recently released and one of its changes to MSVC is that the constructor of `std::mutex` became `constexpr`. According to MSVC's binary compatibility guarantees, a program must use a Visual C++ redistributable version at least as new as the toolset that compiled the program. However, due to [a defect](actions/runner-images#10004) on the GitHub Actions `windows-2022` image, an old redistributable version was picked, causing weird failures in CI. This PR fixes these failures, by defining the `_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR` symbol, which reverts the change to `std::mutex`. Due to unexplained errors, I could not do that for the standalone unit test workflow, and instead I changed that to use the `windows-2019` image which does not exhibit this problem. This PR should be reverted once the issue on GHA gets fixed. --- TYPE: NO_HISTORY
teo-tsirpanis
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3bb0699 from #5057.
TYPE: NO_HISTORY
DESC: Add temporary mitigations for CI failures in windows-2022.