Update to use new routes for group creation. #5543
Conversation
shaunrd0
force-pushed
the
shaunreed/core-251-update-endpoint-for-post_group_create_to_rest
branch
from
0acbc4f to
0066bfc
Compare
|
The endpoint has been changed which causes a 404 when creating a group. But it looks like the new endpoint is not using full URIs like we have in the past for other endpoints, instead it's using a group path like |
We need to work with Server folks to understand why this change to the group routes was needed and what are the implications. This affects more than just group create, I think it affects pretty much all group operations at this point. Let's investigate so that we resort to changes in Core as a last choice. |
ypatia
force-pushed
the
shaunreed/core-251-update-endpoint-for-post_group_create_to_rest
branch
from
0066bfc to
8a4b31b
Compare
ypatia
force-pushed
the
shaunreed/core-251-update-endpoint-for-post_group_create_to_rest
branch
from
cfb4b89 to
b78a65c
Compare
|
I think now this PR addresses all required changes for groups, however I have found issues while testing manually end to end. I have documented the issues here. They are namely errors in adding group members and in creating groups with default storage. |
ypatia
changed the title
|
@shaunrd0 let me know if you are ok with my latest changes and I'll approve and merge. |
|
LGTM, thanks! |
ypatia
deleted the
shaunreed/core-251-update-endpoint-for-post_group_create_to_rest
branch
) Recently the route for group creation was updated from `{workspace}/{teamspace} POST` to `{workspace}/{teamspace}/{group} POST`. This updates `post_group_create_to_rest` to call the new endpoint if we are not communicating with a legacy REST server. It also updates two group routes that were moved under `/contents` for the new server. --- TYPE: BUG DESC: Update to use new route for group creation. --------- Co-authored-by: Ypatia Tsavliri <[email protected]>
|
/backport to release-2.28 |
|
Started backporting to release-2.28: https://github.com/TileDB-Inc/TileDB/actions/runs/16214577327 |
…5543) (#5581) Recently the route for group creation was updated from `{workspace}/{teamspace}` POST to `{workspace}/{teamspace}/{group}` POST. This updates `post_group_create_to_rest` to call the new endpoint if we are not communicating with a legacy REST server. It also updates two group routes that were moved under `/contents` for the new server. --- TYPE: BUG DESC: Update to use new route for group creation. --------- Co-authored-by: Shaun Reed <[email protected]> Co-authored-by: Ypatia Tsavliri <[email protected]>
Recently the route for group creation was updated from
{workspace}/{teamspace} POSTto{workspace}/{teamspace}/{group} POST. This updatespost_group_create_to_restto call the new endpoint if we are not communicating with a legacy REST server.It also updates two group routes that were moved under
/contentsfor the new server.TYPE: BUG
DESC: Update to use new route for group creation.