[Backport release-2.28] Finalize Profile and add example. #5572
+336
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is intended to be the final Profile-related update before the first release that includes the Profile feature. It includes the following changes: - Addresses the comment in #5498 (comment) regarding the use of the `.tiledb` path extension: it is now only appended to the default path (homedir). If the user provides a custom path, nothing is appended. - Removes the constructor of the `RestProfile` class that accepts only the profile name, by assigning default values to the parameters of the other constructor. This simplifies the overall logic. - Makes the internal profile removal function, as well as the C++ API, static. This better aligns with the intended use cases of the feature, as Profiles are rarely created, and it is not logical to require users to create a Profile object just to remove a profile from disk. - Adds a C++ example demonstrating the expected usage of Profiles. Closes CORE-235 --- TYPE: IMPROVEMENT DESC: Finalize Profile feature and add example.
ypatia
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5533 to release-2.28
TYPE: IMPROVEMENT
DESC: Finalize Profile feature and add example.