Merged
Conversation
bekadavis9
force-pushed
the
rd/vfs_refactor-memfs
branch
from
79da456 to
1e296c7
Compare
bekadavis9
force-pushed
the
rd/vfs_refactor-memfs
branch
from
c0117f0 to
67d9a08
Compare
teo-tsirpanis
approved these changes
Jul 8, 2025
| * @return The node of the created file. | ||
| */ | ||
| void touch_internal(const std::string& path, FSNode** node = nullptr) const; | ||
| FSNode* touch_internal(const std::string& path) const; |
Member
There was a problem hiding this comment.
Note: these functions already track the returned nodes in a tdb_unique_ptr, so returning a pointer is OK.
bekadavis9
force-pushed
the
rd/vfs_refactor-memfs
branch
from
67d9a08 to
9294d62
Compare
bekadavis9
force-pushed
the
rd/vfs_refactor-memfs
branch
from
9294d62 to
4da7966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class
MemFSinherits base classFilesystemBase.This is the first PR in the
VFSrefactor work. The primary goal is forMemFSto inherit the base class,FilesystemBase. Some additional changes were made to the base class and toVFSto ease this transition for all other filesystems.TYPE: IMPROVEMENT
DESC: Class
MemFSinherits base classFilesystemBase.Resolves CORE-289