[Backport release-2.28] Update array create to pass the storage path in payload (#5565) #5582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This reverts commit 199a252.
teo-tsirpanis
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new Server the storage path should not be passed in the request endpoint URL, so we need to specify it in the request payload. In Group create case this was already implemented, but for arrays it was not.
This PR fixes it by introducing a new capnp message, array_create_request, to be used with the new TileDB server only. This new message will include, along with array_schema, a storage_uri that will be indicating to the server where the physical storage of the array will be.
TYPE: IMPROVEMENT
DESC: Update array create to pass the storage path in payload