chore: fix and standardize the timetabling UI#1019
chore: fix and standardize the timetabling UI#1019triceo merged 5 commits intoTimefoldAI:developmentfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to standardize/fix the timetabling UI rendering across the Kotlin and Java demos by making the frontend more tolerant of Room/Timeslot references being represented as either full objects or IDs in the returned timetable JSON. It also adjusts backend JSON serialization behavior in the Spring Boot integration module.
Changes:
- Add
roomMap/timeslotMapcaches and anextractId()helper to normalize rendering when fields may be objects vs IDs. - Update schedule refresh to rebuild these maps prior to rendering.
- Remove
@JsonPropertyOrderfrom the Spring Boot integrationTimetabledomain class.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| kotlin/school-timetabling/src/main/resources/META-INF/resources/app.js | Adds ID extraction + room/timeslot lookup maps to render schedule using resolved objects. |
| java/school-timetabling/src/main/resources/META-INF/resources/app.js | Same UI standardization as Kotlin module. |
| java/spring-boot-integration/src/main/resources/static/app.js | Same UI standardization as other modules. |
| java/spring-boot-integration/src/main/java/org/acme/schooltimetabling/domain/Timetable.java | Removes explicit JSON property ordering that can affect identity/reference serialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
java/spring-boot-integration/src/main/java/org/acme/schooltimetabling/domain/Timetable.java
Show resolved
Hide resolved
java/school-timetabling/src/main/resources/META-INF/resources/app.js
Outdated
Show resolved
Hide resolved
kotlin/school-timetabling/src/main/resources/META-INF/resources/app.js
Outdated
Show resolved
Hide resolved
triceo
left a comment
There was a problem hiding this comment.
LGTM when formatting fixed.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The PR will have to be rebased and the comments looked at. (Not necessarily accepted.) |
7bc1e9b to
a72d10a
Compare
Description of the change
Checklist
Development
Code Review