Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement immediate mode API #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kstrafe
Copy link
Contributor

@kstrafe kstrafe commented Jun 24, 2019

This is a PR to just get a discussion going about a potential immediate-mode API. This API does not require the user to be concerned with manual_poll or start_polling, and instead does everything via the send and recv calls (now called _immediate for convenience of implementation).

Regarding performance, we can configure whether to run resending, polling the underlying socket, handle idle clients as a function of the Nth recv/send. Ideally we can run all this at every call to avoid any unexpected "why doesn't my packet arrive?" questions.

@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #212 into master will decrease coverage by 0.25%.
The diff coverage is 81.08%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #212      +/-   ##
=========================================
- Coverage   97.45%   97.2%   -0.26%     
=========================================
  Files          25      25              
  Lines        2321    2358      +37     
=========================================
+ Hits         2262    2292      +30     
- Misses         59      66       +7
Impacted Files Coverage Δ
src/net/socket.rs 94.93% <81.08%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf65f8a...ca7dd7d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant